[Invoice] Add new deposited state to prepare moving to AASM
#11254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampoder
reviewed
Aug 10, 2025
rluodev
commented
Aug 27, 2025
sampoder
approved these changes
Sep 5, 2025
sampoder
previously requested changes
Sep 5, 2025
|
@sampoder wdym? |
|
Note from call with Ruien: I believe what @sampoder meant here is that archived should not be an AASM state. This is because archived is an "addition to a state". An invoice would be archived in addition to open/paid/deposited, etc. |
garyhtou
changed the title
_at columnsdeposited state to prepare moving to AASM
garyhtou
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
lots of random columns
Describe your changes
this centralizes those into AASM. Next PR will be to migrate all AASM states with a migration and change any pages to use the correct state.