[Wise] Add a field to track the recipient ID #11255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcornu
force-pushed
the
david/push-yuzytwuolkrv
branch
from
f7424e0 to
b7a8a1b
Compare
|
ty <3 |
sampoder
reviewed
Aug 10, 2025
db/schema.rb
Outdated
| @@ -11,6 +11,7 @@ | |||
| # It's strongly recommended that you check this file into your version control system. | |||
|
|
|||
| ActiveRecord::Schema[7.2].define(version: 2025_08_08_033500) do | |||
|
|
|||
There was a problem hiding this comment.
It should definitely not. I must have added it when fixing a merge conflict.
YodaLightsabr
approved these changes
Aug 11, 2025
| @@ -1,6 +1,6 @@ | |||
| <% if @hcb_code.wise_transfer.wise_id.present? %> | |||
| <% if @hcb_code.wise_transfer.wise_url %> | |||
There was a problem hiding this comment.
nit: do we still want to call .present? here
There was a problem hiding this comment.
We do already in the implementation of wise_url so didn't think it necessary. Happy to add it if you think it's clearer.
db/schema.rb
Outdated
| @@ -11,6 +11,7 @@ | |||
| # It's strongly recommended that you check this file into your version control system. | |||
|
|
|||
| ActiveRecord::Schema[7.2].define(version: 2025_08_08_033500) do | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
We want to keep track of the Wise recipient ID when marking transfers as complete.
Describe your changes
wise_recipient_idcolumn to thewise_transferstable (nomenclature comes from https://docs.wise.com/api-docs/api-reference/recipient#get)wise_recipient_idfield to theWiseTransfermodel (similar to Wise bug fixes part 1 #11252)