fix: type casting for exact match search parameter of name stone sear…#291
Merged
fix: type casting for exact match search parameter of name stone sear…#291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NameStoneで一部の名前が登録できないバグを修正しました！
具体的には、name stoneのsearchNamesのexact_matchが0または1の数字のみしか受け付けない仕様らしく、そこにtrueが入っていたため、exact_matchが機能していなかったようです。
例えば、
yawncが登録されていると、yawn,yaw,yaなど一部マッチするより少ない文字列の名前が登録されないようになっていたみたいです。りょーまさんが他の部分でexact_matchに使っていたコードを流用し、解決しました！