Skip to content

Conversation

@pluto-bell
Copy link
Member

Fixes #1464

What changes did you make and why did you make them ?

  • Added .toLowerCase() across front-end files that were calling or creating emails. If you try to sign in with various uppercase and lowercase letters, your email is now still recognized; New users emails should all resolve to lowercase to help stop duplicates.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Screen Capture - Login Example First example shows fix, second example shows bug
Screen.Recording.2024-11-11.at.4.10.08.PM.mov

@pluto-bell
Copy link
Member Author

pluto-bell commented Nov 12, 2024

Note/Question

I noticed I could create new users with invalid emails and that there is no created issue for this bug. I originally created a fix but removed it incase I'm not supposed to handle additional bugs this way.

Should I submit a new issue instead of adding the fix here?

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b pluto-bell-add-tolowercase-db-query development
git pull https://github.com/pluto-bell/VRMS.git add-tolowercase-db-query

@JackHaeg
Copy link
Member

Closing PR, as it will be merged into the correct-db-casing feature branch.

@JackHaeg
Copy link
Member

Update as of March 25, 2025 - this PR has been merged into the feature branch: correct-db-casing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add .toLowerCase to front end auth db query

2 participants