Skip to content

Conversation

@dannyprikaz
Copy link
Member

Fixes #1700

Note:

This seems to be an unused component, but I went ahead and made the changes anyways.

What changes did you make and why did you make them ?

  • Replaced HTML div tag with MUI Box componenet
  • Replaced HTML button tag with MUI Button component
  • Replaced HTML textarea tag with MUI TextareaAutosize component
  • Replaced HTML input tag with MUI TextField component
  • WHY: To modernize the editableMeeting.jsx component using MUI

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

1700 pre no-edit mode
1700 pre edit mode

Visuals after changes are applied

1700 post no-edit mode
1700 post edit mode

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b dannyprikaz-issue1700-editable-fileds-mui development
git pull https://github.com/dannyprikaz/VRMS.git issue1700-editable-fileds-mui

Copy link
Member

@sasszz sasszz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low risk because it is an unused component, approved

@dannyprikaz dannyprikaz added the ready for 2nd review When a PR is ready for another reviewer label Feb 6, 2025
@hollydo hollydo self-requested a review February 11, 2025 03:16
@hollydo
Copy link
Contributor

hollydo commented Feb 11, 2025

Changes looks good to me. @JackHaeg or @trillium can we merge this issue?

@JackHaeg JackHaeg added the ready for dev lead Add to issue when dev lead needs to take some action label Feb 19, 2025
@JackHaeg
Copy link
Member

JackHaeg commented Feb 19, 2025

@trillium Can we merge this PR? Looks like we have 2 approving reviews from Holly & Lucie. Looks like some of the fields may be slightly misaligned (e.g., "edit" is contained on a separate line from "Some Field")...

@JackHaeg
Copy link
Member

JackHaeg commented Mar 4, 2025

@dannyprikaz if possible, please update the CSS to fix the alignment issue discussed above.

@dannyprikaz
Copy link
Member Author

dannyprikaz commented Mar 4, 2025

@dannyprikaz if possible, please update the CSS to fix the alignment issue discussed above.

@JackHaeg @trillium
I made changes to improve the styling in commit 885879f

Visuals after new changes are applied

1700 post no-edit mode new fix

1700 post edit mode new fix

@JackHaeg
Copy link
Member

JackHaeg commented Mar 4, 2025

Thanks for making these changes, @dannyprikaz - looks great!!
@trillium Okay if we go ahead and merge?

@trillium trillium merged commit 8eb907d into hackforla:development Mar 11, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: small ready for dev lead Add to issue when dev lead needs to take some action ready for 2nd review When a PR is ready for another reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/manageProjects/editableField.js

5 participants