-
-
Notifications
You must be signed in to change notification settings - Fork 97
Update HTML components to MUI components for ManageProjects page #1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTML components to MUI components for ManageProjects page #1850
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
dannyprikaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor notes about changing styling and which MUI components were used, but this solution works. I approve
bconti123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes on VRMS website. Everything works. MUI code looks much cleaner!
bconti123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trillium, I added ready for dev lead. label.
|
@JackHaeg This issue is ready to merge. Shall I proceed? |
|
@jng34 Just following up on this merge - now that the branch has been updated, please feel free to go ahead and click "Merge pull request" even though the checks are failing. |
Fixes #1719
What changes did you make and why did you make them ?
spantag with MUITypographycomponentimgtag with MUIBoxcomponentScreenshots of Proposed Changes Of The Website
Visuals before changes are applied
Visuals after changes are applied