Skip to content

Conversation

@jng34
Copy link
Member

@jng34 jng34 commented Jan 30, 2025

Fixes #1719

What changes did you make and why did you make them ?

  • Replaced HTML span tag with MUI Typography component
  • Replaced HTML img tag with MUI Box component
  • Added custom style properties to match original CSS
  • WHY: To modernize the frontend components

Screenshots of Proposed Changes Of The Website

Visuals before changes are applied 1719 before screen
Visuals after changes are applied 1719 after screen

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jng34-updateMUIforManageProjects development
git pull https://github.com/jng34/VRMS.git updateMUIforManageProjects

Copy link
Member

@dannyprikaz dannyprikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor notes about changing styling and which MUI components were used, but this solution works. I approve

@dannyprikaz dannyprikaz added the ready for 2nd review When a PR is ready for another reviewer label Feb 6, 2025
Copy link
Member

@bconti123 bconti123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes on VRMS website. Everything works. MUI code looks much cleaner!

@bconti123 bconti123 added the ready for dev lead Add to issue when dev lead needs to take some action label Feb 18, 2025
Copy link
Member

@bconti123 bconti123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trillium, I added ready for dev lead. label.

@jng34
Copy link
Member Author

jng34 commented Feb 25, 2025

@JackHaeg This issue is ready to merge. Shall I proceed?

@dannyprikaz
Copy link
Member

dannyprikaz commented Feb 25, 2025

@JackHaeg This issue is ready to merge. Shall I proceed?

Hey, @jng34, I think that based on the conversation last night, you're good to go.

@JackHaeg
Copy link
Member

JackHaeg commented Feb 25, 2025

@jng34 Yep, feel free to go ahead and merge. I reached out to @trillium to confirm, but he hasn't respond yet.

One request - I'd recommend clicking on the Update branch button first prior to merging.

@JackHaeg
Copy link
Member

@jng34 Just following up on this merge - now that the branch has been updated, please feel free to go ahead and click "Merge pull request" even though the checks are failing.

@jng34 jng34 merged commit c6f5fcb into hackforla:development Feb 26, 2025
2 of 5 checks passed
@jng34 jng34 deleted the updateMUIforManageProjects branch September 23, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: small ready for dev lead Add to issue when dev lead needs to take some action ready for 2nd review When a PR is ready for another reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/pages/ManageProjects.js

4 participants