-
-
Notifications
You must be signed in to change notification settings - Fork 97
Fixes #1472 - Create withAuth component to manage automatic redirect to login page #1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey, Bryant. I like the hook that you set up. It looks like it's working well, but I think there's one more component, |
|
Thank you for pointing out the component I missed. I am working on |
dannyprikaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resolved a conflict on the ManageProjects.jsx page, and it looks like everything is working properly. Thanks, @bconti123
|
Confirmed that PR is ready for a 2nd review. |
kurtmgray
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool hook, all functionality remains. Fixed one merge conflict in App.jsx.
Fixes #1472
What changes did you make and why did you make them?
withAuthhook to manage automatic redirect to login page.Events,UserAdmin,ProjectList, andManageProjectscomponents.authto the props ofManageProjectsandProjectListcomponents.withAuthhook as a comment inApp.jsx.withAuthcomponent will be added to the new component.ProjectFormcomponent andindex.jsxdue to the complexity of the code. Updated: 02/28/2025 - Removed the redirect method in theProjectFormandadmin/dashboard/index.jscomponents. ThewithAuthhook works.