Fixes #1472 - Create withAuth component to manage automatic redirect to login page#1852
Merged
bconti123 merged 10 commits intohackforla:developmentfrom Mar 11, 2025
Merged
Conversation
Member
|
Hey, Bryant. I like the hook that you set up. It looks like it's working well, but I think there's one more component, |
Member
Author
|
Thank you for pointing out the component I missed. I am working on |
dannyprikaz
approved these changes
Mar 4, 2025
Member
dannyprikaz
left a comment
There was a problem hiding this comment.
I resolved a conflict on the ManageProjects.jsx page, and it looks like everything is working properly. Thanks, @bconti123
Member
|
Confirmed that PR is ready for a 2nd review. |
kurtmgray
approved these changes
Mar 11, 2025
Member
kurtmgray
left a comment
There was a problem hiding this comment.
Cool hook, all functionality remains. Fixed one merge conflict in App.jsx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1472
What changes did you make and why did you make them?
withAuthhook to manage automatic redirect to login page.Events,UserAdmin,ProjectList, andManageProjectscomponents.authto the props ofManageProjectsandProjectListcomponents.withAuthhook as a comment inApp.jsx.withAuthcomponent will be added to the new component.ProjectFormcomponent andindex.jsxdue to the complexity of the code. Updated: 02/28/2025 - Removed the redirect method in theProjectFormandadmin/dashboard/index.jscomponents. ThewithAuthhook works.