generated from hackforla/.github-hackforla-base-repo-template
-
-
Notifications
You must be signed in to change notification settings - Fork 97
User permissions search #1853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
User permissions search #1853
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
947c325
Added an API that fetches all the admins
ntrehan 76f2927
Added API that fetches all projectManagers
ntrehan 5e8ea4a
Merge branch 'development' of https://github.com/hackforla/vrms into …
ntrehan 460068f
Fixes to issue #1752
jng34 ee1f3f4
fixes #1752
jng34 7c842cc
Add redesigned Users page
vorleakyek 7d5bfe9
Create redesigned Users page with two buttons link to users-search an…
vorleakyek 29f1c9b
undo deletion of package.json and yarn.lock
vorleakyek abdc330
Update div to box
vorleakyek 1819aad
PR #1808 update & fixes
jng34 95e3814
Add redesigned Users page
vorleakyek 663e4c5
Create redesigned Users page with two buttons link to users-search an…
vorleakyek 6d7b3fd
undo deletion of package.json and yarn.lock
vorleakyek b02b441
Update div to box
vorleakyek 3123e02
Add search functionality and link to the user profile
vorleakyek bbf2963
add comments for clarification
vorleakyek c91b2e6
Merge branch 'development' into filteredPermissionsDataComp
jng34 ed2661f
Merge pull request #1831 from ntrehan/1769
trillium 88f9b77
Merge pull request #1832 from vorleakyek/redesign-users-screen-1751
trillium 9898ba9
Merge branch 'user_permissions_search' into filtered-permission-1754
trillium 2953cae
Merge pull request #1833 from vorleakyek/filtered-permission-1754
trillium 8b4b5d6
Merge branch 'user_permissions_search' into filteredPermissionsDataComp
trillium 2138f31
Merge pull request #1834 from jng34/filteredPermissionsDataComp
trillium a536ef3
Merge pull request #1835 from ntrehan/1771
trillium ca8449d
remove dummy data and hook up API for admins
vorleakyek 306ef90
hook up project manager API to display the data on the console
vorleakyek 20727b1
Updated the project managers API and display the data for the project…
vorleakyek 9b45efa
Update the filtered data to show users with 'superadmin'
vorleakyek f15a433
Refactor the code in the backend to make it cleaner
vorleakyek 36da6f7
Merge branch 'development' into user_permissions_search
trillium b82ad0e
resolve the empty nav element and remove the dummy data comment
vorleakyek cfd85f4
Merge branch 'development' into user_permissions_search
trillium 2e49857
Update the API to fetch the project leads and the frontend to work pr…
vorleakyek 4306fea
remove console log
vorleakyek 7d81629
Merge branch 'development' into user_permissions_search
JackHaeg f71c70f
Merge branch 'development' into user_permissions_search
jng34 c13569b
Merge branch 'development' into user_permissions_search
trillium File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you return (push) the
projectIdin addition to thename?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jng34, The projectId is already included as part of the admins data. So, I think we don't need to push it.
The API for the admins is returning this data object

The API for the project leads is returning this data object

So, I want to check if we should include the
isProjectLeadandmanagedProjectNamesproperties in the API that fetches all the admin as well?Thanks for taking a look at the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vorleakyek
Got it, thanks for the screenshots.
Regarding the
isProjectLeadandmanagedProjectNamesproperties, I think including those in the API fetch for admins would be a good idea if the user wants to know that info about a specific admin when clicking on his/her profile.I guess that depends on what
accessLevel('user', 'admin', 'superadmin') does the user have and what info do we want each to be able to see.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your input @jng34!
@ntrehan, could you tell us what you think since you worked on the fetch admin API ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion with @trillium, it should be okay to not include
isProjectLeadandmanagedProjectNamesas part of the admins API.