1487 backend test fixes #1876
Merged
1487 backend test fixes #1876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
trillium
approved these changes
Mar 19, 2025
Member
trillium
left a comment
trillium
left a comment
There was a problem hiding this comment.
Thanks for your work here Danny!
| "test:client": "cd client && npm run test", | ||
| "test:client-mvp": "cd client-mvp-04 && npm run test", | ||
| "test:all": "cross-env NODE_ENV=test npm run test:client && npm run test:client-mvp && npm run test:backend && npm run test:cy" | ||
| "test:all": "cross-env NODE_ENV=test npm run test:client && npm run test:backend" |
Member
There was a problem hiding this comment.
Writing for clarity here that we're removing test:client-mvp and test:cy
Member
|
I don't really have notes to provide because I don't understand this test suite all that much at the moment, but its been broken for a minute and we're moving towards getting it resolved!~ |
This was referenced Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1487
What changes did you make and why did you make them ?
Fixed backend tests so that they all pass (most of the time)
backend/models/project.test.jsby puttingsetupDBmethod inbeforeAllit was creating infinite regression.setupDBhas abeforeAllblock inside it.backend/models/user.test.js, same asbackend/models/project.test.jsbackend/workers/createRecurringEvents.test.jsmocked versions of all methods were being imported because ofbackend/jest.setup.jsline 15jest.mock('./workers/createRecurringEvents');. None of the expected calls were happening. Usingjest.requireActualfixes the problem.backend/workers/createRecurringEvents.test.jsthere were several error logs that could be fixed by setting a default resolved value forfetchAdjusted `package.json` so that `npm run test:all` will successfully complete client and backend tests.
package.jsontest:allwas referencing outdated scripts forclient-mvpand was terminating before backend tests. Also, cypress tests are not working because of a lack of a custom header.NOTE
Some tests are still failing intermittently due to some configuration issue, likely with the setting up of Mongoose. This needs more investigation, but it seemed worthwhile to fix these tests while I was working on it.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied