Skip to content

Conversation

@dannyprikaz
Copy link
Member

Fixes #1898

What changes did you make and why did you make them ?

  • Moved all old tests from routers directory to test/old-tests
  • Updated jest.config.js to ignore the path to that new directory
  • Looks like globalConfig.json was also changed. This should have been in the gitignore, but it will be deleted soon.

@trillium
Copy link
Member

trillium commented Apr 9, 2025

Looks like globalConfig.json was also changed. This should have been in the gitignore, but it will be deleted soon.

Re: this, I found that when I added a step to check on the staged changes before committing, less unintentional code got into my PRs. Current workflow for me looks like:

  • Use VSCode inbuilt git integration to stage specific sections of files
  • Use terminal to check staged changes in VSCode with side-by-side changes in main window
    • git diff --staged
  • If any code got in by accident or I want to change/remove what is in this commit, unstage that file and start this process again
  • (repeat 1-2 times?)
  • Commit and push

If that's helpful, great! If it was just a fluke, please disregard :)

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks for getting this process going @dannyprikaz

@dannyprikaz dannyprikaz merged commit ffb5e84 into hackforla:development Apr 10, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move old tests from routers directory into a new directory and skip them

2 participants