Unit testing for Recurring Events router

[jng34]

Fixes #1894

What changes did you make and why did you make them ?

• Wrote unit tests for recurringEvents.router
• Wrote tests for fail cases
• Fixed minor bug in catch block of the "/internal" route in recurringEvents.router

Screenshots of Passed Tests

[dannyprikaz]

Hey @jng34

You're killing it with these PRs. As I was going through some of these, I realized that I was being lazy with my own tests of routes that were passing the request to a controller, and I ultimately found a solution that I think you should apply to these tests as well.

Prime example is line 137 of backend/routers/recurringEvents.router.test.js. Right now we're just expecting that the create method is being called, but we really want to make sure it's being called with the correct input, namely newEvent. The problem that I was having (and that I'm sure you ran into), is that the controller method is getting passed a ton more than just newEvent. I found a solution, that I put in the comments here and that I incorporated into my own PR. Please update your code to use this expectation where necessary.

Thanks!

[jng34]

@dannyprikaz
Thank you again for your review and pointers.
It is making a lot more sense now with the specifications of the tests.
I have made the updates. Please review once more when you have time.

[jng34]

@dannyprikaz please hold off on reviewing this PR. I am currently working on writing tests for error handling as we discussed last week. I will drop a comment to let you know when I have added those tests and the PR is ready for review again.

[JackHaeg]

Hi @jng34 FYI - I added the waiting to merge label to this PR since we are holding off on reviewing / merging while you work on writing tests for error handling. Once this PR is ready for review, please tag Danny in a comment and remove this label from the PR :)

[jng34]

@dannyprikaz
The PR has been updated and ready for review.

[dannyprikaz]

Looks good!