Unit testing for Questions router

[jng34]

Fixes #1893

What changes did you make and why did you make them ?

• Wrote unit tests for questions.router

Screenshots of Passed Tests

[dannyprikaz]

Hey, James. These tests look good for the success scenarios,, but like we discussed with Angela last week, when the logic we are testing has failing scenarios, we should add tests for those as well. I included an example in my comments.

[jng34]

@dannyprikaz
Added testing for all fail cases.

[dannyprikaz]

Hey, @jng34 . This all looks good to me. As a note for the future, I think this code could be a little DRYer. This applies to the last PR I approved as well, for the recurring events. We could define a constant for mockDatabaseError or something like that up top. Then we could use that as the mockRejectedValue for Question.find and Question.create. That would save a couple of lines. More impactful, I think we could define consoleLogSpy up top and then move consoleLogSpy.mockRestore() to the afterEach block, if that mockRestore call isn't already covered by jest.clearAllMocks()

Something to think about!