Skip to content

Conversation

@bconti123
Copy link
Member

Fixes #1917

What changes did you make and why did you make them ?

  • I added @media (max-width:450px) for the mobile screen on VRMS logos aligned, because the changing padding on the desktop platform will affect the mobile platform.
  • Changed padding to padding: 3vh for desktop and padding: 1vh 1vh 3vh 1vh for mobile.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

OGvrms

Visuals after changes are applied desktop mobile

@bconti123 bconti123 changed the title fix-align-VRMS-logo Fix Align VRMS logo May 16, 2025
@angela-lee1 angela-lee1 self-requested a review May 18, 2025 22:33
@trillium
Copy link
Member

image
image

Discussing these screenshots on the call tongiht

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Hey Bryant, thanks for working on this!

Can we get the two divs on the page to have the same level of distance from the left edge?

If you need to add an internal div on the page feel free to, doesn't need to only be changes to the CSS file.

If possible as well I'd prefer if we steer away from using vh measurements for padding becuase of the way they vary. This might have been there already, feel free to clean up and change any padding/margin based vh units if you see them

@bconti123
Copy link
Member Author

@trillium, Thank you for your feedback. I will work on and look into improving the responsive design.

@bconti123
Copy link
Member Author

bconti123 commented May 20, 2025

@trillium

I made the two divs have similar CSS (home-headers and home-bottons), and the alignment looks better. I removed padding and added margin-top and margin-bottom in home-headers from home.scss.

Let me know if any changes are needed.

@JackHaeg
Copy link
Member

Hi @trillium! Can you please take a look at the updates @bconti123 made when you have a chance?

@trillium
Copy link
Member

trillium commented Jun 3, 2025

Hey hey, from the call today, would you mind making sure that the container width doesnt reduce as a result of this PR?

Thanks :)

@trillium
Copy link
Member

trillium commented Jun 3, 2025

image

As per chat, lets have the outside container establish boundaries for the content

Please use em units

@bconti123
Copy link
Member Author

Hi @trillium, I updated the layout and replaced vh units with em units. I think I might have misunderstood part of what we discussed about the container in the previous Zoom meeting last week. I want to confirm. Is that yellow line outside the container we discussed? See screenshot below:

Yellow Line outside the app container

LogoPaddingShow

I would like to discuss the app container and share my screen in the meeting tonight.
Let me know what I should fix ahead of time. Thank you!

@angela-lee1 angela-lee1 removed their request for review June 15, 2025 14:53
@trillium
Copy link
Member

trillium commented Jun 17, 2025

Hey Bryant, sorry to take so long here.

I feel like I've overcomplicated this. It's fine as it is now, happy to merge

@bconti123 bconti123 merged commit 48318d5 into hackforla:development Jun 17, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align VRMS Logo on Landing Page

3 participants