-
-
Notifications
You must be signed in to change notification settings - Fork 97
Fix Align VRMS logo #1932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Align VRMS logo #1932
Conversation
trillium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Bryant, thanks for working on this!
Can we get the two divs on the page to have the same level of distance from the left edge?
If you need to add an internal div on the page feel free to, doesn't need to only be changes to the CSS file.
If possible as well I'd prefer if we steer away from using vh measurements for padding becuase of the way they vary. This might have been there already, feel free to clean up and change any padding/margin based vh units if you see them
|
@trillium, Thank you for your feedback. I will work on and look into improving the responsive design. |
|
I made the two divs have similar CSS ( Let me know if any changes are needed. |
|
Hi @trillium! Can you please take a look at the updates @bconti123 made when you have a chance? |
|
Hey hey, from the call today, would you mind making sure that the container width doesnt reduce as a result of this PR? Thanks :) |
|
Hi @trillium, I updated the layout and replaced vh units with em units. I think I might have misunderstood part of what we discussed about the container in the previous Zoom meeting last week. I want to confirm. Is that yellow line outside the container we discussed? See screenshot below: I would like to discuss the app container and share my screen in the meeting tonight. |
|
Hey Bryant, sorry to take so long here. I feel like I've overcomplicated this. It's fine as it is now, happy to merge |




Fixes #1917
What changes did you make and why did you make them ?
@media (max-width:450px)for the mobile screen on VRMS logos aligned, because the changing padding on the desktop platform will affect the mobile platform.padding: 3vhfor desktop andpadding: 1vh 1vh 3vh 1vhfor mobile.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied