Skip to content

Conversation

@angela-lee1
Copy link
Member

Fixes #1919

What changes did you make and why did you make them?

  • Enable enter key submission on the admin login page

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He Angela, thanks for your work here.

This looks a little overengineered, overall we prefer to continue to use built in HMTL functionality to submit the form. It looks like we just need to wrap the FormControl component and a form component and then we should be good.

Make sure to move the properties from the FormControl component into the form component

// Move from <FormControl> to <form>
          onSubmit={handleLogin}
          className="form-check-in"
          autoComplete="off"

@angela-lee1
Copy link
Member Author

angela-lee1 commented May 20, 2025

@trillium, @JackHaeg, I made changes per your comments. Please take a look at it when you have a chance. Thanks.

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes, approved :)

@angela-lee1 angela-lee1 merged commit ea064ad into hackforla:development May 28, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable "Enter" Key Submission on Login Forms

2 participants