Skip to content

Conversation

@jng34
Copy link
Member

@jng34 jng34 commented Jul 3, 2025

Fixes #1976

What changes did you make and why did you make them ?

  • Fixed bug to now show both admins and users under the Project Members tab in UserPermissionSearch
  • Deleted the unused component UserPermissionSearch in the directory src/pages, which is a duplicate of currently used UserPermissionSearch in the directory src/components/user-admin to avoid confusion
  • Updated User model to return correct type (array of ProjectIds) in managedProjects field
  • Updated Project model with the require validation for the name field
  • Updated users.router.test after changes in the user.controller

Screenshots of Proposed Changes Of The Website

Visuals before changes are applied image
Visuals after changes are applied userpermPM1 userpermPM2

@JackHaeg
Copy link
Member

JackHaeg commented Jul 4, 2025

Thanks so much for putting together this PR so quickly, @jng34!!

@JackHaeg
Copy link
Member

@trillium Can you please take a look at this PR when you have a second? Once this is merged, we can rebuild Dev (and potentially Prod following testing).

@trillium
Copy link
Member

@JackHaeg Looking at it now

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes James

There's a few other things that I'd like changed about how this query works, but I see that those problems weren't introduced via this PR so we'll address them in a separate issue.

@jng34 jng34 merged commit dac077f into hackforla:development Jul 15, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Project Leads filter only shows Admins, not all users linked to projects

3 participants