Skip to content

Create routes and methods for updating User and Project 'ManagedBy' fields #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jng34 merged 10 commits into from
Sep 23, 2025
Merged

Create routes and methods for updating User and Project 'ManagedBy' fields #1988

jng34 merged 10 commits into from
Sep 23, 2025

Conversation

@jng34
Copy link
Member

@jng34 jng34 commented Jul 23, 2025

Fixes #1987

What changes did you make and why did you make them ?

  • Created new controller methods UserController.updateManagedProjects and ProjectController.updateManagedByUsers to simultaneously update (add/remove) db for related user and project
  • Created new user route /:UserId/managedProjects and new project route /:ProjectId for the respective methods
  • Updated relevant client side files to properly call the UserController.updateManagedProjects when a user adds or removes a project.

@jng34 jng34 requested a review from trillium July 23, 2025 20:40
@jng34
Copy link
Member Author

jng34 commented Jul 23, 2025

@trillium
I configured the client side files to test the new method. When you get a chance to review, please let me know if I should revert the changes to the client side files and keep the new methods and routes separate for this PR.

@JackHaeg JackHaeg mentioned this pull request Jul 29, 2025
Closed
3 tasks
@JackHaeg
Copy link
Member

JackHaeg commented Jul 29, 2025

@jng34 is adding unit tests to this PR and will remove the "waiting to merge" label once this PR is ready to be reviewed.

@JackHaeg
Copy link
Member

JackHaeg commented Jul 29, 2025

Hi @jng34! I saw that you added / removed the waiting to merge label after making a few new commits. Is this issue ready to review?

@jng34
Copy link
Member Author

jng34 commented Jul 29, 2025

@JackHaeg I forgot add one more test and will update the "waiting to merge" label once more when the PR is ready.

@jng34
Copy link
Member Author

jng34 commented Jul 29, 2025

@JackHaeg
Ready for review.

@JackHaeg
Copy link
Member

JackHaeg commented Jul 29, 2025

@JackHaeg JackHaeg mentioned this pull request Aug 5, 2025
Open
trillium
trillium requested changes Sep 22, 2025
View reviewed changes
Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is looking good! Please resolve these two things and we can merge it :)

trillium
trillium approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work here James :D

client/src/api/UserApiService.js Outdated
}
return undefined;
}
// // Updates user projects in db
Copy link
Member

@trillium trillium Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this commented out function

@jng34 jng34 merged commit 9307f59 into hackforla:development Sep 23, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trillium trillium trillium approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create user.controller and project.controller functions to update model

3 participants

@jng34 @JackHaeg @trillium