Added Amen Divine Ikamba to Hack for LA site #7900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
phunguyen1195
suggested changes
Feb 7, 2025
Member
phunguyen1195
left a comment
phunguyen1195
left a comment
There was a problem hiding this comment.
Thank you for working on this issue! Everything looks good! just one small edit.
What you did well
- PR is made with the correct branch.
- The correct issue is linked.
- The correct member is added.
- The Hack for LA Site displays correctly on browser, iPad, and iPhone.
- Code changes align with the issue requirements.
- No additional issues introduced.
What needs fixed
Remove the paragraph above Fixes #7855 in your pr comment.
Please re-request a review from me once it is fixed. Thank you!
Member
Author
|
@phunguyen1195 I believe I fixed it. Please let know |
phunguyen1195
approved these changes
Feb 7, 2025
Member
phunguyen1195
left a comment
phunguyen1195
left a comment
There was a problem hiding this comment.
Yes, great job! this PR is approved :)
Member
Author
|
@phunguyen1195 Thank you! |
Kle012
approved these changes
Feb 8, 2025
Member
Kle012
left a comment
Kle012
left a comment
There was a problem hiding this comment.
Approved. Great job!
- Pull request done with the correct branch
- Linked issue
- Change displayed correctly in the browser
Love what you have done. Thank you.
31 tasks
This was referenced Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7855
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied