Skip to content

Conversation

@rogerioduenas
Copy link
Member

@rogerioduenas rogerioduenas commented Feb 8, 2025

Fixes #7844

What changes did you make?

  • Add Katiuska Alecea de Leon's profile to leadership in _projects/vrms.md

Why did you make the changes (we will use this info to test)?

  • We need to keep project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

before

Visuals after changes are applied

after

@github-actions
Copy link

github-actions bot commented Feb 8, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b rogerioduenas-update-add-katiuska-alecea-7844 gh-pages
git pull https://github.com/rogerioduenas/HfLA_website.git update-add-katiuska-alecea-7844

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 8, 2025
@TheManTheMythTheGameDev
Copy link
Member

Review ETA: 1:30 PM 2/8/25
Availability: 7-9 PM Weekdays

Copy link
Member

@TheManTheMythTheGameDev TheManTheMythTheGameDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here!
This pull request:

  • Has the correct branches
  • Links the relevant issue
  • Makes the proper changes

Approved! Thank you for contributing to Hack for LA.

Copy link
Member

@gmgonzal gmgonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rogerioduenas, thank you for working on this issue! Your code changes look good. That said, you will need to change the PR title so that the linked issue number is removed (this is stated on the contributing wiki):

Things You Did Well:

  • Step 0: PR is done with the correct branch.
    • PR description looks good.
  • Step 1: PR links to the correct issue #7844
  • Step 2: Changes appear to address the issue action items.
  • Step 3: Website page looks good on the browser.
  • Step 4: Source code changes look good.
  • Step 5: No other issues seen.

Things You Need to Change:

  • Please remove the linked Issue (#7844) from the PR title.

Once this change is made, I will approve the PR.

@rogerioduenas rogerioduenas changed the title Update Project Profile: VRMS Add Katiuska Alecea de Leon (#7844) Update Project Profile: VRMS Add Katiuska Alecea de Leon Feb 10, 2025
@rogerioduenas
Copy link
Member Author

Hello @gmgonzal, thank you for your review! I made the change you requested. Have a great week 🙂

Copy link
Member

@gmgonzal gmgonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Title was updated to remove the linked issue. PR is approved. Good job!

@daras-cu daras-cu merged commit 549dfcb into hackforla:gh-pages Feb 11, 2025
11 checks passed
@rogerioduenas rogerioduenas deleted the update-add-katiuska-alecea-7844 branch February 24, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: VRMS Add Katiuska Alecea de Leon

4 participants