-
-
Notifications
You must be signed in to change notification settings - Fork 844
Update Project Profile: VRMS Add Katiuska Alecea de Leon #7902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile: VRMS Add Katiuska Alecea de Leon #7902
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 1:30 PM 2/8/25 |
TheManTheMythTheGameDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here!
This pull request:
- Has the correct branches
- Links the relevant issue
- Makes the proper changes
Approved! Thank you for contributing to Hack for LA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rogerioduenas, thank you for working on this issue! Your code changes look good. That said, you will need to change the PR title so that the linked issue number is removed (this is stated on the contributing wiki):
Things You Did Well:
- Step 0: PR is done with the correct branch.
- PR description looks good.
- Step 1: PR links to the correct issue #7844
- Step 2: Changes appear to address the issue action items.
- Step 3: Website page looks good on the browser.
- Step 4: Source code changes look good.
- Step 5: No other issues seen.
Things You Need to Change:
- Please remove the linked Issue (#7844) from the PR title.
Once this change is made, I will approve the PR.
|
Hello @gmgonzal, thank you for your review! I made the change you requested. Have a great week 🙂 |
gmgonzal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Title was updated to remove the linked issue. PR is approved. Good job!
Fixes #7844
What changes did you make?
leadershipin_projects/vrms.mdWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied