-
-
Notifications
You must be signed in to change notification settings - Fork 844
Added Brad Morgan in VMRS leadership #7903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: EOD 2/12/25 |
DrAcula27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Khinememe-Kyaw Great job on your Good First Issue! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
_projects/vrms.mdwas edited - No extra edits were made
- Appearance of the website looks good (Chrome and Firefox)
Approved! 👍
|
Hi @DrAcula27, I resolved a conflict in this PR and your previous review was canceled. I apologize for any inconvenience. I hope I didn't make any mistakes, as I’m new here and still getting used to the workflow. If possible, could you review it again? Thank you for your understanding! 😁 |
aadilahmed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on your first issue @Khinememe-Kyaw ! You added the new profile to the leadership section of the VRMS project page, and correctly created the pull request. Great work!
DrAcula27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Khinememe-Kyaw Great job on your Good First Issue! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
_projects/vrms.mdwas edited - No extra edits were made
- Appearance of the website looks good (Chrome and Firefox)
Approved! 👍
|
Hi @Khinememe-Kyaw! I just merged an older PR that changed this file and it created a conflict. Please pull the upstream gh-pages into your local gh-pages and incorporate the changes into your local VRMS-add-7849 branch and push your local VRMS-add-7849 again. It should automatically add the changes to this PR. Feel free to reach out directly to me on Slack if you have any questions! |
0b32656
|
I have pulled the upstream gh-pages and pushed the VRMS-add-7849 branch. But I'm not sure if the issue is resolved. I noticed that the two approved reviews are gone and the message about the branch having conflicts is still there. Could you please let me know if there is anything else I have to fix? Thank you! |
* update github text * only modify instance of github on line 509
DrAcula27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Khinememe-Kyaw PR still looks good to me. Thanks!
Sujay-Anantha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Khinememe-Kyaw Great Job on the PR. Things you did well:
- The PR was created from the correct branch and properly linked to the corresponding issue (#7849 ).
- Only the specified section in _projects/vrms.md was updated with no unnecessary changes.
- Verified that the changes align with the attached screenshot.
- CodeQL alerts have been checked.
f5f2ea5
|
Hi @Khinememe-Kyaw You wrote:
Unfortunately, yes, you still have conflicts that need to be resolved before this can be merged. You can try to resolve the conflict with the "Checkout via command line" note below, and/or if you are attending the Tuesday or Thursday meeting this week someone can help you with this. If all else fails, there is the option of closing this PR, and then starting over with a new branch, make the edits, and submit a new PR. |
@t-will-gillis I am sorry I have only work on project alone and I don't know how to solve merge conflict. Please let me know whatI can do to solve it. Thank you! And yes, I will be at the meeting on Tuesday
|
|
@Khinememe-Kyaw No problem- sometimes the merge conflicts get messy. If you are going on Tuesday, be sure to let the host know that you need help with a merge conflict. |


Fixes #7849
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied