Skip to content

Conversation

@DDVVPP
Copy link
Member

@DDVVPP DDVVPP commented Feb 14, 2025

Fixes #7850

What changes did you make?

  • Added Evan Yang to the leadership variable in the vrms markdown file

Why did you make the changes (we will use this info to test)?

  • To keep the list of current project team members up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied current project team-before
Visuals after changes are applied current projec team-after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b DDVVPP-add-evan-yang-to-project-profile-7850 gh-pages
git pull https://github.com/DDVVPP/HackForLA-Website.git add-evan-yang-to-project-profile-7850

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 14, 2025
Copy link
Member

@coding-yost coding-yost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, everything looks in order! congrats on a successful review!

@santiseccovidal
Copy link
Member

Review ETA: 6 PM 2/16/25
Availability: 12-2 PM Sunday

Copy link
Member

@santiseccovidal santiseccovidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DDVVPP everything looks good: changes added in your code and screenshots. The changes reflect correctly running Docker locally too. Thanks for working on this.

A tip for next time, you can delete the note above "Fixes #7850" for next time

@santiseccovidal santiseccovidal self-requested a review February 17, 2025 01:16
@daras-cu daras-cu merged commit adc7c2a into hackforla:gh-pages Feb 19, 2025
11 of 15 checks passed
@DDVVPP DDVVPP deleted the add-evan-yang-to-project-profile-7850 branch February 19, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: VRMS Add Evan Yang

4 participants