Skip to content

Conversation

@coding-yost
Copy link
Member

@coding-yost coding-yost commented Feb 14, 2025

Fixes #7438

What changes did you make?

  • replaced 2 instances of Github with GitHub on line 24

Why did you make the changes (we will use this info to test)?

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

![image]Screenshot 2025-02-14 105403

Visuals after changes are applied

![image]Screenshot 2025-02-14 105221

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/coding-yost/website/blob/Replace-Github-with-GitHub-in-CONTRIBUTING.md-Table-of-Contents-1.4.c/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 14, 2025
@coding-yost coding-yost self-assigned this Feb 14, 2025
@Cloid Cloid self-requested a review February 14, 2025 20:36
@Cloid
Copy link
Member

Cloid commented Feb 14, 2025

Review ETA: EOD 2/22/25
Availability: 5-8 PM Weekdays

@gmgonzal gmgonzal self-requested a review February 17, 2025 22:52
@gmgonzal
Copy link
Member

Review ETA: 4p 2/17/25
Availability: 9a-4p 2/17/25

Copy link
Member

@gmgonzal gmgonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @coding-yost, thank you for working on this issue. Your changes look good!

Things You Did Well:

  • Step 0: PR is done with the correct branch.
    • Issue title looks good.
    • PR description looks good.
  • Step 1: PR links to the correct issue #7438.
  • Step 2: Changes appear to address the issue action items.
  • Step 3: Website page looks good on the browser.
  • Step 4: Source code changes look good.
  • Step 5: No other issues seen.

PR is approved, well done :)

@iancooperman
Copy link
Member

ETA: Fri, 2/21
Availability: 5-9pm Weekdays

Copy link
Member

@iancooperman iancooperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @coding-yost,

Great job on this!

  • All requested changes have been made without anything out of scope.
  • Action items on the original issue are properly checked off.

Just a quick note for the future:

  • The branch title was appropriately named, but remember to include the issue number at the end next time (e.g., coding-yost:Replace-Github-with-GitHub-in-CONTRIBUTING.md-Table-of-Contents-1.4.c-7438).

Overall, everything looks solid. Nice work! Approved.

@t-will-gillis
Copy link
Member

t-will-gillis commented Feb 23, 2025

Hey @coding-yost Just a minor note: you don't need to assign yourself to the PR. Also, for the next one, please be sure to remove excess lines for example in "What changes did you make?" Otherwise, looks good, thanks!

@t-will-gillis t-will-gillis merged commit bd65699 into hackforla:gh-pages Feb 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Replace Github with GitHub in CONTRIBUTING.md Table of Contents 1.4.c

5 participants