-
-
Notifications
You must be signed in to change notification settings - Fork 844
replaces 2 instances of Github with GitHub on line 24 #7910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaces 2 instances of Github with GitHub on line 24 #7910
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
|
Review ETA: EOD 2/22/25 |
|
Review ETA: 4p 2/17/25 |
gmgonzal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @coding-yost, thank you for working on this issue. Your changes look good!
Things You Did Well:
- Step 0: PR is done with the correct branch.
- Issue title looks good.
- PR description looks good.
- Step 1: PR links to the correct issue #7438.
- Step 2: Changes appear to address the issue action items.
- Step 3: Website page looks good on the browser.
- Step 4: Source code changes look good.
- Step 5: No other issues seen.
PR is approved, well done :)
|
ETA: Fri, 2/21 |
iancooperman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @coding-yost,
Great job on this!
- All requested changes have been made without anything out of scope.
- Action items on the original issue are properly checked off.
Just a quick note for the future:
- The branch title was appropriately named, but remember to include the issue number at the end next time (e.g., coding-yost:Replace-Github-with-GitHub-in-CONTRIBUTING.md-Table-of-Contents-1.4.c-7438).
Overall, everything looks solid. Nice work! Approved.
|
Hey @coding-yost Just a minor note: you don't need to assign yourself to the PR. Also, for the next one, please be sure to remove excess lines for example in "What changes did you make?" Otherwise, looks good, thanks! |
Fixes #7438
What changes did you make?
Why did you make the changes (we will use this info to test)?
To ensure company name is presented properly
For Reviewers: Do not review changes locally, rather, review changes at https://github.com/coding-yost/website/blob/Replace-Github-with-GitHub-in-CONTRIBUTING.md-Table-of-Contents-1.4.c/CONTRIBUTING.md
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
![image]
Visuals after changes are applied
![image]