-
-
Notifications
You must be signed in to change notification settings - Fork 844
Remove Bryce Lednar from Home Unite Us #7928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Bryce Lednar from Home Unite Us #7928
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: EOD 2/19/25 |
lc1715
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Khinememe-Kyaw, you did a great job on your good first issue! The PR was done with the correct branch, linked issue, and the correct changes can be seen in the browser!
One change you could make:
- Not all of the Action Items in the issue was checked off. Please make sure to check off all Action Items in the linked issue.
For the future, consider adding more detail to your branch name such as "homeuniteus-remove-Bryce-Lednar-7476" for more clarity.
Thank you for working this issue!
coding-yost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great, Great job @Khinememe-Kyaw! In the future be sure to assign yourself as assignee on the pr and issue so we know who is working on what.
Everything else looks perfect thank you for the hard work!
|
Review ETA: EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Khinememe-Kyaw , thank you for taking on this issue.
Things you did well:
- PR is done with the correct branch.
- PR contains correctly formatted linked issue.
- CodeQL Alerts have been properly checked.
- Before and after screenshots are appropriately included.
- PR follows correct format and is properly written.
- The changes are applicable to the issue.
- Website is still user-friendly and links and components still work as intended.
- Source code changes are applicable and clean.
Suggested changes:
- None
Notes:
- Can give more detail for future issue branch names, for example
update-project-profile-remove-bryce-lednar-7476. No need to change your branch name for this issue. - Remember to check off boxes for completed items on linked issue.
- Can include a more specific location of markdown file for future explanations under “What changes did you make?,” for example,
_projects/home-unite-us.md.
Thank you for your hard work @Khinememe-Kyaw , I approve this PR.
Fixes #7476
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied