Skip to content

Conversation

@Khinememe-Kyaw
Copy link
Member

@Khinememe-Kyaw Khinememe-Kyaw commented Feb 19, 2025

Fixes #7476

What changes did you make?

  • Remove Bryce Lednar from Home Unite Us

Why did you make the changes (we will use this info to test)?

  • To keep the website up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Khinememe-Kyaw-homeuniteus-remove-7476 gh-pages
git pull https://github.com/Khinememe-Kyaw/website.git homeuniteus-remove-7476

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 19, 2025
@lc1715 lc1715 self-requested a review February 20, 2025 00:24
@lc1715
Copy link
Member

lc1715 commented Feb 20, 2025

Review ETA: EOD 2/19/25
Availability: 1-7 PM Mon-Fri

Copy link
Member

@lc1715 lc1715 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Khinememe-Kyaw, you did a great job on your good first issue! The PR was done with the correct branch, linked issue, and the correct changes can be seen in the browser!

One change you could make:

  • Not all of the Action Items in the issue was checked off. Please make sure to check off all Action Items in the linked issue.

For the future, consider adding more detail to your branch name such as "homeuniteus-remove-Bryce-Lednar-7476" for more clarity.

Thank you for working this issue!

Copy link
Member

@coding-yost coding-yost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, Great job @Khinememe-Kyaw! In the future be sure to assign yourself as assignee on the pr and issue so we know who is working on what.

Everything else looks perfect thank you for the hard work!

@katiejnete
Copy link
Member

Review ETA: EOD
Availability: 7-10 PM, Wednesday

Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Khinememe-Kyaw , thank you for taking on this issue.

Things you did well:

  • PR is done with the correct branch.
  • PR contains correctly formatted linked issue.
  • CodeQL Alerts have been properly checked.
  • Before and after screenshots are appropriately included.
  • PR follows correct format and is properly written.
  • The changes are applicable to the issue.
  • Website is still user-friendly and links and components still work as intended.
  • Source code changes are applicable and clean.

Suggested changes:

  • None

Notes:

  • Can give more detail for future issue branch names, for example update-project-profile-remove-bryce-lednar-7476. No need to change your branch name for this issue.
  • Remember to check off boxes for completed items on linked issue.
  • Can include a more specific location of markdown file for future explanations under “What changes did you make?,” for example, _projects/home-unite-us.md.

Thank you for your hard work @Khinememe-Kyaw , I approve this PR.

@LRenDO LRenDO merged commit d8e1e20 into hackforla:gh-pages Feb 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Home Unite Us Remove Bryce Lednar

5 participants