-
-
Notifications
You must be signed in to change notification settings - Fork 843
Update Project Profile- Website: Remove Thinking-Panda #7931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile- Website: Remove Thinking-Panda #7931
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 4 PM PT 02/21/25 |
DDVVPP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoanhua14 Great job on your good first issue!
- The pull request is made with the correct branch
- The issue is correctly linked
- Nikileshwari Prasadh has been removed from projects/website per issue requirements
Additional comment (no changes needed!): I noticed that the members are displayed in a different order than the way they are displayed in the deployed hackforla site, but verified that the code in the PR wasn't creating that difference by comparing the codebases and the 'Files changed.'
coding-yost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are effective and work. Thank you for the hard work.
- issue linked correctly to pr
- all changes clean the issue at hand
|
Hi @DDVVPP It appears that you submitted your Approval as comment rather than as a review. Please resubmit your comment as a review. Thanks! |
DrAcula27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoanhua14 Great job on your Good First Issue! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
_projects/website.mdwas edited - Appearance of the website looks good (Chrome and Firefox)
- Note: you removed some extra whitespace on line 35, which is fine; however, if this was done because you have a code formatter (like Prettier) running on your HackForLA repo, I highly recommend you disable it for that repo. In the long run, especially as you take on more complex issues, this can cause a lot of headache and unintentionally modifying the code base. For now though, I think this is good to approve.
Thanks for your work! Approved! 👍
|
Hi @DrAcula27 ,I noticed the issue but wasn't sure why it happened. I disabled Prettier to prevent this in the future. Thank you for the feedback. |
DDVVPP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoanhua14 Great job on your good first issue!
- The pull request is made with the correct branch
- The issue is correctly linked
- Nikileshwari Prasadh has been removed from projects/website per issue requirements
Additional comment (no changes needed!): I noticed that the members are displayed in a different order than the way they are displayed in the deployed hackforla site, but verified that the code in the PR wasn't creating that difference by comparing the codebases and the 'Files changed.'
Fixes #7775
What changes did you make?
_projects/website.mdfile, removed:Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied