Skip to content

Conversation

@hoanhua14
Copy link
Member

@hoanhua14 hoanhua14 commented Feb 21, 2025

Fixes #7775

What changes did you make?

  • Within _projects/website.md file, removed:
  - name: Nikileshwari Prasadh
    github-handle: Thinking-Panda
    role: Merge Team
    links:
      slack: 'https://hackforla.slack.com/team/U04MJA414LU'
      github: 'https://github.com/Thinking-Panda'
    picture: https://avatars.githubusercontent.com/Thinking-Panda

Why did you make the changes (we will use this info to test)?

  • We need to keep project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied bfore
Visuals after changes are applied after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b hoanhua14-update-project-profile-website-remove-thinking-panda-7775 gh-pages
git pull https://github.com/hoanhua14/hackforlawebsite.git update-project-profile-website-remove-thinking-panda-7775

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 21, 2025
@DDVVPP DDVVPP self-requested a review February 21, 2025 21:49
@DDVVPP
Copy link
Member

DDVVPP commented Feb 21, 2025

Review ETA: 4 PM PT 02/21/25
Availability: 11 AM - 5 PM PT Tue-Fri

Copy link
Member

@DDVVPP DDVVPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoanhua14 Great job on your good first issue!

  • The pull request is made with the correct branch
  • The issue is correctly linked
  • Nikileshwari Prasadh has been removed from projects/website per issue requirements

Additional comment (no changes needed!): I noticed that the members are displayed in a different order than the way they are displayed in the deployed hackforla site, but verified that the code in the PR wasn't creating that difference by comparing the codebases and the 'Files changed.'

Copy link
Member

@coding-yost coding-yost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are effective and work. Thank you for the hard work.

  • issue linked correctly to pr
  • all changes clean the issue at hand

@t-will-gillis
Copy link
Member

Hi @DDVVPP It appears that you submitted your Approval as comment rather than as a review. Please resubmit your comment as a review. Thanks!

@rogerioduenas rogerioduenas requested review from rogerioduenas and removed request for rogerioduenas February 24, 2025 04:34
Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoanhua14 Great job on your Good First Issue! Your code passed the ABC's, including:

  • PR is made from the correct branch
  • PR links to the correct issue:
  • The correct file _projects/website.md was edited
  • Appearance of the website looks good (Chrome and Firefox)
  • Note: you removed some extra whitespace on line 35, which is fine; however, if this was done because you have a code formatter (like Prettier) running on your HackForLA repo, I highly recommend you disable it for that repo. In the long run, especially as you take on more complex issues, this can cause a lot of headache and unintentionally modifying the code base. For now though, I think this is good to approve.
    Thanks for your work! Approved! 👍

@hoanhua14
Copy link
Member Author

Hi @DrAcula27 ,I noticed the issue but wasn't sure why it happened. I disabled Prettier to prevent this in the future. Thank you for the feedback.

@t-will-gillis t-will-gillis merged commit 74ff986 into hackforla:gh-pages Feb 26, 2025
9 checks passed
Copy link
Member

@DDVVPP DDVVPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoanhua14 Great job on your good first issue!

  • The pull request is made with the correct branch
  • The issue is correctly linked
  • Nikileshwari Prasadh has been removed from projects/website per issue requirements

Additional comment (no changes needed!): I noticed that the members are displayed in a different order than the way they are displayed in the deployed hackforla site, but verified that the code in the PR wasn't creating that difference by comparing the codebases and the 'Files changed.'

@hoanhua14 hoanhua14 deleted the update-project-profile-website-remove-thinking-panda-7775 branch March 2, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile- Website: Remove Thinking-Panda

5 participants