-
-
Notifications
You must be signed in to change notification settings - Fork 844
Update Project Profile: Website- remove Roslyn Wythe #7932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile: Website- remove Roslyn Wythe #7932
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 4 PM PT 02/21/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsnhn Great job on your good first issue!
- The pull request is made with the correct branch
- The issue is correctly linked
- Roslyn Wythe has been removed from projects/website per issue requirements
Minor suggestion: I noticed that there are no CodeQL alerts in your PR (yay!), so it would be nice to check off that box in your PR comment next time! Same comment applies to the checkboxes in your issue.
coding-yost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Please be more specific in your title (Who is being removed from what project page) and be sure to check off everything such as your CodeQL checks.
Your issue links correctly and everything else looks great. Thank you for your hard work.
t-will-gillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jsnhn Congrats on your first HfLA PR! Everything looks great:
- branches from and to are good
- issue is linked correctly
- the "What did you do..." and "Why did you do it.." sections are concise and appropriate
- there are relevant before and after screenshots of the website changes
The only- minor- comments are to please check the appropriate box for the CodeQL alert (ie. "I have checked this PR for CodeQL alerts and none were found.") and please edit the PR title to be more descriptive, for example "Remove Roslyn Wythe from Website profile" or "Update Project Profile: Website- remove Roslyn Wythe".
Again this looks great, thanks for contributing, and when you make the edits make sure to re-request a review from me.
t-will-gillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsnhn for making the edits!
Fixes #7843
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied