Skip to content

Conversation

@jsnhn
Copy link
Member

@jsnhn jsnhn commented Feb 21, 2025

Fixes #7843

What changes did you make?

  • Removed Roslyn Wythe's information from _projects/website.md

Why did you make the changes (we will use this info to test)?

  • To keep list of active HfLA members on the website up-to-date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Screenshot 2025-02-20 at 3 47 35 PM

Visuals after changes are applied

Screenshot 2025-02-20 at 3 48 32 PM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jsnhn-remove-website-info-7843 gh-pages
git pull https://github.com/jsnhn/website.git remove-website-info-7843

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 21, 2025
@DDVVPP DDVVPP self-requested a review February 21, 2025 21:12
@DDVVPP
Copy link
Member

DDVVPP commented Feb 21, 2025

Review ETA: 4 PM PT 02/21/25
Availability: 11 AM - 5 PM PT Tue-Fri

Copy link
Member

@DDVVPP DDVVPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsnhn Great job on your good first issue!

  • The pull request is made with the correct branch
  • The issue is correctly linked
  • Roslyn Wythe has been removed from projects/website per issue requirements

Minor suggestion: I noticed that there are no CodeQL alerts in your PR (yay!), so it would be nice to check off that box in your PR comment next time! Same comment applies to the checkboxes in your issue.

Copy link
Member

@coding-yost coding-yost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Please be more specific in your title (Who is being removed from what project page) and be sure to check off everything such as your CodeQL checks.

Your issue links correctly and everything else looks great. Thank you for your hard work.

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jsnhn Congrats on your first HfLA PR! Everything looks great:

  • branches from and to are good
  • issue is linked correctly
  • the "What did you do..." and "Why did you do it.." sections are concise and appropriate
  • there are relevant before and after screenshots of the website changes

The only- minor- comments are to please check the appropriate box for the CodeQL alert (ie. "I have checked this PR for CodeQL alerts and none were found.") and please edit the PR title to be more descriptive, for example "Remove Roslyn Wythe from Website profile" or "Update Project Profile: Website- remove Roslyn Wythe".

Again this looks great, thanks for contributing, and when you make the edits make sure to re-request a review from me.

@jsnhn jsnhn changed the title Removes team member from project profile Update Project Profile: Website- remove Roslyn Wythe Feb 25, 2025
@jsnhn jsnhn requested a review from t-will-gillis February 25, 2025 22:18
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsnhn for making the edits!

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Feb 26, 2025
@t-will-gillis t-will-gillis merged commit 6d38a3c into hackforla:gh-pages Feb 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Website Remove Roslyn Wythe

4 participants