Skip to content

Conversation

@t-will-gillis
Copy link
Member

@t-will-gillis t-will-gillis commented Feb 21, 2025

Fixes #7881

What changes did you make?

  • In check-complexity-eligiblity.js and preliminary-update-comments.js, changed label from Ready for Prioritization to Status: Unassigned by Bot
  • In label-directory.json, edited key by removing "NEW-" prepend from "statusUnassignedByBot"

Why did you make the changes (we will use this info to test)?

  • The replacement label will be used as a flag to let Product know that the issue was previously prioritized, and therefore does not need to be reviewed again- only prioritized.
  • The prepend is initially added to the label key by the bot to let us know the key is new. It is no longer needed.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No changes to the website

Change label `Ready for Prioritization` --> `Status: Unassigned by Bot`
Change label `Ready for Prioritization` --> `Status: Unassigned by Bot`
Remove "NEW-" prepend from the "statusUnassignedByBot" key
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-change-label-for-unassigned-7881 gh-pages
git pull https://github.com/t-will-gillis/website.git change-label-for-unassigned-7881

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 3pt Can be done in 13-18 hours labels Feb 21, 2025
Edited the console.log() comment for clarity
Copy link
Member

@coding-yost coding-yost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All changes look correct and as requested
  • pr links to issue
  • great title and responses

You're good to go from me, this all looks amazing. Thank you for the hard work.

@gmgonzal gmgonzal self-requested a review February 24, 2025 20:02
Copy link
Member

@gmgonzal gmgonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @t-will-gillis, thank you for working on this issue. Your changes look good.

Things You Did Well:

  • Step 0: PR is done with the correct branch.
    • Issue title looks good.
    • PR description looks good.
  • Step 1: PR links to the correct issue #7881.
  • Step 2: Changes appear to address the issue action items.
  • Step 3: No visual changes made to the website.
  • Step 4: Source code changes look good.
  • Step 5: No other issues seen.

PR is approved, well done :)

@t-will-gillis t-will-gillis merged commit 8c0623f into hackforla:gh-pages Feb 25, 2025
5 checks passed
@t-will-gillis t-will-gillis deleted the change-label-for-unassigned-7881 branch February 25, 2025 03:18
@ExperimentsInHonesty ExperimentsInHonesty added the Lang: GHA GitHub Actions label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Change label for issues unassigned by bot to Status: Unassigned by Bot

4 participants