Removed Emily Eldar's leadership variable #7936

Christopher-Chhim · 2025-02-23T05:21:16Z

What changes did you make?

Removed Emily Eldar's leadership variables from _projects/home-unite-us.md

Why did you make the changes (we will use this info to test)?

To keep list of active HfLA project profiles up-to-date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

I have checked this PR for CodeQL alerts and none were found.
I found CodeQL alert(s), and (select one):
- I have resolved the CodeQL alert(s) as noted
- I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
- I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Visuals after changes are applied

github-actions · 2025-02-23T05:21:43Z

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Christopher-Chhim-home-unite-us-7484 gh-pages
git pull https://github.com/Christopher-Chhim/website.git home-unite-us-7484

coding-yost

Title needs to be more specific, and reason for change needs to be more specific. Please check the CodeQL options.

Requested change: Before and After Images links are broken.

pr links to issue correctly
changes are clean and useful

All other changes are great, Thank you for your hard work.

coding-yost

Please review requirements, working before and after images need to be uploaded before approval.

All other changes look great and the issue will be approved once proper documentation of before and after images have been properly uploaded.

siyunfeng · 2025-02-26T19:45:04Z

@rogerioduenas , please comment with your Availability and Review ETA once you assign this PR.

katiejnete · 2025-02-27T01:55:49Z

Review ETA: EOD 2/26/25
Availability: 6-9 PM Wednesday

katiejnete

Hi @Christopher-Chhim , thank you for taking on this issue.

Things you did well:

PR is done with the correct branch.
PR contains correctly formatted linked issue.
PR follows correct format.
The changes are applicable to the issue.
Website is still user-friendly and links and components still work as intended.
Source code changes are applicable and clean.

Suggested changes:

Under “what changes did you make,” please be more specific on which markdown file did you remove the project profile from: _projects/home-unite-us.md.
Under “why did you make the changes,” please make your reason relevant to the issue and something like To keep list of active HfLA project profiles up-to-date.
CodeQL Alerts have not been properly checked. Please check if PR had any CodeQL alerts. Then, please check the correct checkbox on this PR under “CodeQL Alerts”.
Before and after screenshots are not appropriately included and do not properly load. Please drag and drop the screenshot images and wait for them to finish uploading.

Notes:

In the future, please make your issue branch name more detailed and relate it to the issue. Please follow the correct scheme/format. For example, the issue Update ‘Give’ image credit link and information - #2093 should have this branch name: update-give-link-2093. No need to change the issue branch name for this issue.

After making these changes, re-request a review from me. Thank you for your hard work!

rogerioduenas · 2025-02-27T05:22:07Z

Availability: Monday - Friday, 10:00 AM to 4:00 PM JST
ETA: Friday by 4:00 PM JST

Christopher-Chhim · 2025-02-28T05:07:04Z

Hi @Christopher-Chhim , thank you for taking on this issue.

Things you did well:

PR is done with the correct branch.

PR contains correctly formatted linked issue.

PR follows correct format.

The changes are applicable to the issue.

Website is still user-friendly and links and components still work as intended.

Source code changes are applicable and clean.

Suggested changes:

Under “what changes did you make,” please be more specific on which markdown file did you remove the project profile from: _projects/home-unite-us.md.

Under “why did you make the changes,” please make your reason relevant to the issue and something like To keep list of active HfLA project profiles up-to-date.

CodeQL Alerts have not been properly checked. Please check if PR had any CodeQL alerts. Then, please check the correct checkbox on this PR under “CodeQL Alerts”.

Before and after screenshots are not appropriately included and do not properly load. Please drag and drop the screenshot images and wait for them to finish uploading.

Notes:

In the future, please make your issue branch name more detailed and relate it to the issue. Please follow the correct scheme/format. For example, the issue Update ‘Give’ image credit link and information - #2093 should have this branch name: update-give-link-2093. No need to change the issue branch name for this issue.

After making these changes, re-request a review from me. Thank you for your hard work!

I can't access my local repository's live server so I can't provide a picture for after the changes have been applied but I believe it will work.

rogerioduenas · 2025-02-28T05:24:44Z

Hello @Christopher-Chhim :)

I saw here and it seems that you corrected everything that was necessary for your PR to be approved, but putting the photo after the task was done is important, even if it is possible to run your branch locally on the reviewer's machine, it is important that you can complete all the steps for your PR to be approved.

LRenDO · 2025-03-05T16:06:52Z

Hi @Christopher-Chhim! If you need help with running your local environment, I'm happy to help. Feel free to reach out to me on Slack.

siyunfeng · 2025-03-13T20:41:35Z

@Christopher-Chhim , please update the screenshot after you made the change.
If you need help with it, you can reach out to @LRenDO or leave a message with your availability for the week and this PR link on Slack.

dvernon5 · 2025-03-16T19:15:40Z

ETA: EOD 3/16
Avail: Monday-Thursday 12pm - 6pm, Friday 12pm - 4pm

dvernon5

Hello @Christopher-Chhim

Thank you for taking this issue. You're contribution is greatly appreciated.

Things That Done Well

Your PR contains the correct branch.
You successfully linked your issue.
The PR title is informative, as are both the what and why for its changes in the contents.
The website is still functional after changes were made.
The Source Code changes you committed look awesome and the message clear and concise.
The before changes visuals are presented clearly.

Requested Changes

In the Before and After Screenshot section, the Visuals After Changes are Applied image link is broken.
State your Availability to the Original PR you assign yourself to in the comment section.

Once you make those corrections, re-request me, and I will approve this PR. Great job.

t-will-gillis · 2025-03-22T22:54:10Z

Hi @Christopher-Chhim Please leave us a note about when you plan to resolve this PR, and/or whether you need any help with finalizing it.

xnealcarson

Things Done Well

The issue has the correct 'commit into': "hackforla:gh-pages".
The commit from and collaborator names match.
The linked issue is present.
The changes made are applicable and clean.

Suggested Changes

'Visuals after changes are applied' image link is broken. Please fix.

Christopher-Chhim · 2025-03-26T02:59:57Z

I'm free all day on Friday

Christopher-Chhim · 2025-03-26T03:08:32Z

I attached the screenshot after I implemented the changes.

katiejnete · 2025-03-27T22:50:12Z

Hey @Christopher-Chhim, the images are rendering properly, but there is duplicate markdown syntax. Please delete the duplicates before the correctly formatted image tags: from Visual before section ![image](![image](<image_url>) and Visuals after section ![image]![image](<image_url>) to just keep ![image](<image_url>). After making these changes, re-request a review from me. Thank you for your hard work!

Christopher-Chhim · 2025-04-04T04:02:06Z

Hey @Christopher-Chhim, the images are rendering properly, but there is duplicate markdown syntax. Please delete the duplicates before the correctly formatted image tags: from Visual before section ![image](![image](<image_url>) and Visuals after section ![image]![image](<image_url>) to just keep ![image](<image_url>). After making these changes, re-request a review from me. Thank you for your hard work!

I made the necessary changes but unable to re-request a review

katiejnete

Thank you for your hard work @Christopher-Chhim , I approve this PR.

xnealcarson

Changes look great. Awesome job on this PR @Christopher-Chhim !

dvernon5

@Christopher-Chhim

Everything looks great. Great job taking all of the feedback and making the correct changes!

The changes requested have been made.

Removed Emily Eldar's leadership variable

2ddadca

t-will-gillis mentioned this pull request Feb 23, 2025

Changed name and added github handle for 100-automations.md file #7935

Closed

5 tasks

coding-yost suggested changes Feb 23, 2025

View reviewed changes

coding-yost mentioned this pull request Feb 23, 2025

Pre-work Checklist: Developer: Codi Yost #6038

Closed

31 tasks

rogerioduenas self-requested a review February 24, 2025 06:53

Christopher-Chhim requested a review from coding-yost February 25, 2025 04:31

coding-yost previously requested changes Feb 26, 2025

View reviewed changes

katiejnete suggested changes Feb 27, 2025

View reviewed changes

rogerioduenas requested review from rogerioduenas and removed request for rogerioduenas February 27, 2025 04:40

Christopher-Chhim requested a review from katiejnete February 28, 2025 05:07

rogerioduenas closed this Feb 28, 2025

rogerioduenas reopened this Feb 28, 2025

Christopher-Chhim requested a review from coding-yost March 2, 2025 07:42

mugdhchauhan requested a review from dvernon5 March 16, 2025 17:08

xnealcarson self-requested a review March 16, 2025 17:58

dvernon5 requested changes Mar 16, 2025

View reviewed changes

xnealcarson reviewed Mar 24, 2025

View reviewed changes

katiejnete approved these changes Apr 4, 2025

View reviewed changes

t-will-gillis requested review from dvernon5 and xnealcarson April 6, 2025 16:23

xnealcarson approved these changes Apr 6, 2025

View reviewed changes

dvernon5 approved these changes Apr 6, 2025

View reviewed changes

t-will-gillis merged commit 086c821 into hackforla:gh-pages Apr 7, 2025
29 of 31 checks passed

andyvu923 mentioned this pull request Apr 18, 2025

Home unite us remove muyin zheng #8071

Closed

5 tasks

xnealcarson mentioned this pull request Apr 19, 2025

Skills Issue: Developer: Xavier Neal-Carson #7972

Open

Uh oh!

Removed Emily Eldar's leadership variable #7936

Removed Emily Eldar's leadership variable #7936

Uh oh!

Conversation

Christopher-Chhim commented Feb 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes did you make?

Why did you make the changes (we will use this info to test)?

CodeQL Alerts

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Uh oh!

github-actions bot commented Feb 23, 2025

Uh oh!

coding-yost left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coding-yost left a comment

Choose a reason for hiding this comment

Uh oh!

siyunfeng commented Feb 26, 2025

Uh oh!

katiejnete commented Feb 27, 2025

Uh oh!

katiejnete left a comment • edited by Christopher-Chhim Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Things you did well:

Suggested changes:

Notes:

Uh oh!

rogerioduenas commented Feb 27, 2025

Uh oh!

Christopher-Chhim commented Feb 28, 2025

Things you did well:

Suggested changes:

Notes:

Uh oh!

rogerioduenas commented Feb 28, 2025

Uh oh!

LRenDO commented Mar 5, 2025

Uh oh!

siyunfeng commented Mar 13, 2025

Uh oh!

dvernon5 commented Mar 16, 2025

Uh oh!

dvernon5 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Things That Done Well

Requested Changes

Uh oh!

t-will-gillis commented Mar 22, 2025

Uh oh!

xnealcarson left a comment

Choose a reason for hiding this comment

Things Done Well

Suggested Changes

Uh oh!

Christopher-Chhim commented Mar 26, 2025

Uh oh!

Christopher-Chhim commented Mar 26, 2025

Uh oh!

katiejnete commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Christopher-Chhim commented Apr 4, 2025

Uh oh!

katiejnete left a comment

Choose a reason for hiding this comment

Uh oh!

xnealcarson left a comment

Choose a reason for hiding this comment

Uh oh!

dvernon5 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Christopher-Chhim commented Feb 23, 2025 •

edited

Loading

coding-yost left a comment •

edited

Loading

katiejnete left a comment •

edited by Christopher-Chhim

Loading

dvernon5 left a comment •

edited

Loading

katiejnete commented Mar 27, 2025 •

edited

Loading