Skip to content

Conversation

@rogerioduenas
Copy link
Member

@rogerioduenas rogerioduenas commented Feb 25, 2025

Fixes #7605

What changes did you make?

  • This PR changes the label from "ready for dev lead" to "ready for merge team" in skills-issue--developer.md.

Why did you make the changes (we will use this info to test)?

  • I made these changes to ensure consistency with the updated workflow and labeling conventions.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

For Reviewers

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b rogerioduenas-replace-label-skill-issue-developer-7605 gh-pages
git pull https://github.com/rogerioduenas/HfLA_website.git replace-label-skill-issue-developer-7605

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 1pt Can be done in 4-6 hours labels Feb 25, 2025
Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogerioduenas Great job on your Medium Issue! Your code passed the ABC's, including:

  • PR is made from the correct branch
  • PR links to the correct issue:
  • The correct file .github/ISSUE_TEMPLATE/skills-issue--developer.md was edited
  • No extra edits were made
  • Appearance of the website is unchanged (Chrome and Firefox)
    Approved! 👍

@gmgonzal gmgonzal assigned gmgonzal and unassigned gmgonzal Feb 26, 2025
@gmgonzal gmgonzal self-requested a review February 26, 2025 03:13
@gmgonzal
Copy link
Member

Availability: Thur 9a - 2p
ETA: Thur

Copy link
Member

@belunatic belunatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogerioduenas a great job

  • The branch name is on point
  • I love you mentioned the file you made the changes but it would be great if you added the " ` " to make it look like this in skills-issue--developer.md.
  • code changes are on point

great job!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Feb 26, 2025
@mugdhchauhan
Copy link
Member

Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉

@mugdhchauhan mugdhchauhan merged commit b553772 into hackforla:gh-pages Feb 28, 2025
15 checks passed
@gmgonzal gmgonzal removed their request for review February 28, 2025 21:00
@rogerioduenas rogerioduenas deleted the replace-label-skill-issue-developer-7605 branch March 3, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Projects

Development

Successfully merging this pull request may close these issues.

Replace label in skills-issue--developer.md

5 participants