Skip to content

Conversation

@Six5pAdes
Copy link
Member

@Six5pAdes Six5pAdes commented Feb 25, 2025

Fixes #7849

What changes did you make?

  • added Brad Morgan's information to leadership variable in vrms.html

Why did you make the changes (we will use this info to test)?

  • to keep the site up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied before_coding
Visuals after changes are applied after_coding

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Six5pAdes-update-project-profile-vrms-7849 gh-pages
git pull https://github.com/Six5pAdes/website.git update-project-profile-vrms-7849

@Six5pAdes Six5pAdes added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe and removed P-Feature: Projects page https://www.hackforla.org/projects/ labels Feb 25, 2025
@hoanhua14 hoanhua14 assigned hoanhua14 and unassigned hoanhua14 Feb 26, 2025
@hoanhua14
Copy link
Member

Review ETA: 5PM PST 2/26/25
Availability: 8:30AM to 5PM PST Sunday to Thursday

@hoanhua14 hoanhua14 self-requested a review February 26, 2025 00:37
@rogerioduenas rogerioduenas self-requested a review February 26, 2025 02:22
@DDVVPP DDVVPP self-requested a review February 26, 2025 03:15
@DDVVPP
Copy link
Member

DDVVPP commented Feb 26, 2025

Review ETA: EOD 2/28/2025
Availability: 10 AM - 5 PM PT Mon-Fri

Copy link
Member

@hoanhua14 hoanhua14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Six5pAdes , great job on your good first issue! Your code passes the ABC's, including:

  • The pull request is made with the correct branch
  • The issue is correctly linked
  • The intended block of code has been added correctly per the requirements
  • Appearance looks good (Chrome and Firefox)
  • Action items have been checked off accordingly

Changes have been approved. Thank you!

@katiejnete
Copy link
Member

Review ETA: EOD 2/26/25
Availability: Wednesday, 6PM - 9PM

Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Six5pAdes , thank you for taking on this issue.

Things you did well:

  • PR is done with the correct branch.
  • CodeQL Alerts have been properly checked.
  • Before and after screenshots are appropriately included.
  • PR follows correct format and is properly written.
  • The changes are applicable to the issue.
  • Website is still user-friendly and links and components still work as intended.
  • Source code changes are applicable and clean.

Suggested changes:

  • PR does not contain correctly formatted linked issue. Instead of linking the issue with a url of issue in project board view, please type out link issue like so
    Fixes #replace_this_text_with_the_issue_number
    then click on the correct linked issue.

Notes:

  • Backticks (`) can be used to format short snippets of code, example: vrms.html.
  • Under “Why did make the changes…?” “To keep the site up to date” will suffice.

After making these changes, re-request a review from me. Thank you for your hard work!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Feb 27, 2025
@rogerioduenas
Copy link
Member

Availability: Monday - Friday, 10:00 AM to 4:00 PM JST
ETA: Friday by 4:00 PM JST

@Six5pAdes Six5pAdes requested a review from katiejnete February 27, 2025 06:40
Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Six5pAdes , thank you for making the changes. I approve this PR.

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Feb 27, 2025
Copy link
Member

@DDVVPP DDVVPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Six5pAdes Great job on this PR!

  • The pull request is made with the correct branch
  • The issue is correctly linked
  • Brad Morgan has been added to projects/vrms per issue requirements

@rogerioduenas rogerioduenas removed their request for review February 28, 2025 01:46
@mugdhchauhan
Copy link
Member

Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉

@mugdhchauhan mugdhchauhan merged commit 85b6f3e into hackforla:gh-pages Feb 28, 2025
7 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: VRMS Add Brad Morgan

6 participants