-
-
Notifications
You must be signed in to change notification settings - Fork 844
added Brad Morgan to leadership #7947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Brad Morgan to leadership #7947
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 5PM PST 2/26/25 |
|
Review ETA: EOD 2/28/2025 |
hoanhua14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Six5pAdes , great job on your good first issue! Your code passes the ABC's, including:
- The pull request is made with the correct branch
- The issue is correctly linked
- The intended block of code has been added correctly per the requirements
- Appearance looks good (Chrome and Firefox)
- Action items have been checked off accordingly
Changes have been approved. Thank you!
|
Review ETA: EOD 2/26/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Six5pAdes , thank you for taking on this issue.
Things you did well:
- PR is done with the correct branch.
- CodeQL Alerts have been properly checked.
- Before and after screenshots are appropriately included.
- PR follows correct format and is properly written.
- The changes are applicable to the issue.
- Website is still user-friendly and links and components still work as intended.
- Source code changes are applicable and clean.
Suggested changes:
- PR does not contain correctly formatted linked issue. Instead of linking the issue with a url of issue in project board view, please type out link issue like so
Fixes #replace_this_text_with_the_issue_number
then click on the correct linked issue.
Notes:
- Backticks (`) can be used to format short snippets of code, example:
vrms.html. - Under “Why did make the changes…?” “To keep the site up to date” will suffice.
After making these changes, re-request a review from me. Thank you for your hard work!
|
Availability: Monday - Friday, 10:00 AM to 4:00 PM JST |
katiejnete
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Six5pAdes , thank you for making the changes. I approve this PR.
DDVVPP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Six5pAdes Great job on this PR!
- The pull request is made with the correct branch
- The issue is correctly linked
- Brad Morgan has been added to projects/vrms per issue requirements
|
Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉 |
Fixes #7849
What changes did you make?
vrms.htmlWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied