Replaced prompt for adding ready for dev lead label with prompt for adding ready for merge team label

[iancooperman]

Fixes #7606

What changes did you make?

• Edited line 353 to reference the ready for merge team label instead of the ready for dev lead label.

Why did you make the changes (we will use this info to test)?

• The process is being modified so that the merge team can handle more issue reviews.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

• I have checked this PR for CodeQL alerts and none were found.
• I found CodeQL alert(s), and (select one):
  • I have resolved the CodeQL alert(s) as noted
  • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
  • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

For Reviewers

• Use this URL to check the updated issue template: https://github.com/iancooperman/hackforla-website/issues/new?template=project-profile-card-review-and-update.yml

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

• No visual changes to the website

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b iancooperman-replace-label-in-profile-card-review-7606 gh-pages
git pull https://github.com/iancooperman/hackforla-website.git replace-label-in-profile-card-review-7606

[iancooperman]

What the heck? Why are there so many commits in this? This only touches one line of one file...

[belunatic]

@iancooperman

What went well:

• Although the task had a lot of step, you took care of each one of them great job
• Code was updated to match the changes
• branch name is relevance and matches the objective

Things to consider:

• in the "What changes you made" add the filepath and the line you changed
• Checking of the CodeQL Alert

Great work @iancooperman and thank you

[Cloid]

Review ETA: EOD 3/07/25
Availability: 5-8 PM Weekdays

[gmgonzal]

Review ETA: EOD 2/28/25
Availability: 11-4 PM Weekdays

[gmgonzal]

Hi @iancooperman, thank you for working on this issue. Your code changes look good, but I did not see the changes reflected on the URL to check the updated issue template:

Things You Did Well:

• Step 0: PR is done with the correct branch.
  • Issue title looks good.
  • PR description looks good.
• Step 1: PR links to the correct issue #7606.
• Step 2: Changes appear to address the issue action items.
• Step 3: No visual changes to website page.
• Step 4: Source code changes look good.
• Step 5: No other issues seen.

Things You Need to Check:

• Check why changes are not reflected on the URL shared (https://github.com/iancooperman/hackforla-website/issues/new?template=project-profile-card-review-and-update.yml)

Did you see the changes reflected on your end? If so, perhaps there is an issue with the URL shared. It looks like perhaps the default branch was not switched to the issue branch. Here is a screenshot of what I am seeing when I click the URL:

Screenshot

[ajb176]

Hey @iancooperman

Yeah, I'm not seeing the changes in the template either, are you?

Could you double check and make sure your default branch is set to your PR branch? Otherwise by default we'd be viewing the gh-pages version which doesn't contain the updates. When I click on your fork I'm in gh-pages by default.

[ajb176]

Specifically make sure you've checked the issues checkbox mentioned in the linked issue and have set your default branch to: replace-label-inprofile-card-review-7606

This just seems like a case of the link posted not matching the branch where the changes are made.

[iancooperman]

Specifically make sure you've checked the issues checkbox mentioned in the linked issue and have set your default branch to: replace-label-inprofile-card-review-7606

This just seems like a case of the link posted not matching the branch where the changes are made.

I changed the default branch back to gh-pages. It should be working now—try the link again.

[gmgonzal]

I am now able to see the change reflected in the URL link shared. Well done!

[ajb176]

Looks good now, nice work.

I think the multiple commits are coming from syncing the PR branch with the HFLA repository before starting. You can avoid this by syncing your gh-pages branch first, and then creating a new branch to make the changes.