-
-
Notifications
You must be signed in to change notification settings - Fork 844
Update Project Profile: Website Add Daniel & Kristen & Move Amen, Samhitha, & Priyanka up #7950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile: Website Add Daniel & Kristen & Move Amen, Samhitha, & Priyanka up #7950
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
coding-yost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are in order and look great.
PR issue is linked, all requested changes have been added in the correct order
I am approving these changes. Thank you for your hard work.
|
Availability: Sunday- Thursday from 8:30AM to 5PM PST |
hoanhua14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DDVVPP ,
I love what you've done here, everything is clean, neat, and follows exactly what is required in the issue as well as Hack for LA's practices.
- Correct issue was linked
- PR is done with the correct branch
- Changes were made accordingly
- Action items were checked off
- Appearance of the website looks good
- All checks have passed
PR is approved, thank you.
Fixes #7824
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied