Skip to content

Conversation

@lc1715
Copy link
Member

@lc1715 lc1715 commented Feb 27, 2025

Fixes #7440

What changes did you make?

In CONTRIBUTING.md Section 2.7.e, I replaced:

Your fork of this repository on GitHub, and your local clone of that fork, will get out of sync with this (upstream) repository from time to time. (That's what has happened when you see something like "This branch is 1 commit behind hackforla:gh-pages" on the github website version of your hackforla repository.)

with

Your fork of this repository on GitHub, and your local clone of that fork, will get out of sync with this (upstream) repository from time to time. (That's what has happened when you see something like "This branch is 1 commit behind hackforla:gh-pages" on the GitHub website version of your hackforla repository.)

AND I replaced:

If you go to your online github repository this should remove the message "This branch is x commit behind hackforla:gh-pages".

with

If you go to your online GitHub repository this should remove the message "This branch is x commit behind hackforla:gh-pages".

Why did you make the changes (we will use this info to test)?

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/lc1715/website/blob/Replace-github-with-GitHub-in-CONTRIBUTING.md-7440/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Feb 27, 2025
@gmgonzal gmgonzal self-requested a review March 1, 2025 01:44
@gmgonzal
Copy link
Member

gmgonzal commented Mar 1, 2025

ETA: EOD 3/4
Availability: Weekdays 11a - 3p

Copy link
Member

@gmgonzal gmgonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lc1715, thank you for working on this issue. Your changes look good!

Things You Did Well:

  • Step 0: PR is done with the correct branch.
    • Issue title looks good.
    • PR description looks good.
  • Step 1: PR links to the correct issue #7440.
  • Step 2: Changes appear to address the issue action items.
  • Step 3: No visual changes to the website, but shared link for reviewers looks good.
  • Step 4: Source code changes look good.
  • Step 5: No other issues seen.

PR is approved, well done :)

Copy link
Member

@coding-yost coding-yost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look accurate. PR links to issue. all checks cleared. This looks great thank you for the hard work. Changes approved.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Mar 1, 2025
@t-will-gillis t-will-gillis merged commit 57e6297 into hackforla:gh-pages Mar 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Replace github with GitHub in CONTRIBUTING.md Section 2.7.e

4 participants