-
-
Notifications
You must be signed in to change notification settings - Fork 844
corrected misspellings for envirONment card #7980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrected misspellings for envirONment card #7980
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Monday - Friday, 10:00 AM to 4:00 PM JST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Six5pAdes!
Great job with this PR!
- The branching was done correctly.
- Issue number was listed.
- The PR title is descriptive of the changes.
- Changes were made correctly in the code.
- Changes appear correctly on the repository.
- The PR request clearly states what was updated.
Necessary to correct!
-
In "Why did you make the changes" you should delete the lines you didn't use.

-
Please check the checkbox if you have reviewed this PR for CodeQL alerts and found none.
Not necessary to change, but a good improvement!
-
You can simplify the description to something like: 'Fixed a typo in file
_program-areas/environment-card.ymland also in the path of file/assets/images/program-areas/environment.png, where "environment" was misspelled as "envirnoment".' -
Since your PR doesn't make any visual changes that need to be verified, you could replace the images you attached with 'No visual changes to the website'.
Once you make these changes, your PR will be approved. Thanks for your hard work and your time!
|
Review ETA: EOD 3/5/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Six5pAdes , thank you for taking on this issue.
Things you did well:
- PR is done with the correct branch.
- PR contains correctly formatted linked issue.
- The changes are applicable to the issue.
- Website is still user-friendly and links and components still work as intended.
Suggested changes
- If there are no visual changes to the website, delete all of the script below "Screenshots of Proposed Changes To The Website" and just keep the "- No visual changes to the website"
- Please make sure to use Docker to test changes locally at
localhost:4000/program-areasand check if links and components work as intended. Then, please check off corresponding checkbox on the linked issue.
Notes:
- Please delete spaces in the CodeQL Alerts checkbox, change from
[ x ]to[x]to properly render the checked checkbox. - I noticed there were YAML formatting changes (removing spaces), but they were not related to the requested spelling fix. Consider keeping only the necessary changes requested from the linked issue so that the diffs do not clutter the commit history.
After making these changes, re-request a review from me. Thank you for your hard work!
katiejnete
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work @Six5pAdes , I approve this PR.
Thank you very much for making the corrections and for your hard work, your PR has been approved, congratulations. |
|
Hi @Six5pAdes,
Thank you for contributing and your time. |

Fixes #7629
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)