Skip to content

Conversation

@Six5pAdes
Copy link
Member

@Six5pAdes Six5pAdes commented Mar 4, 2025

Fixes #7629

What changes did you make?

  • changed the Environment card on the Program Areas page so its image filename is spelled correctly (ie: environment vs envirnoment)

Why did you make the changes (we will use this info to test)?

  • keeping the site up to date, correcting spellings

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Six5pAdes-correct-card-misspelling-7629 gh-pages
git pull https://github.com/Six5pAdes/website.git correct-card-misspelling-7629

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Program Area https://www.hackforla.org/program-areas time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours feature: spelling labels Mar 4, 2025
@rogerioduenas rogerioduenas self-requested a review March 5, 2025 06:00
@rogerioduenas
Copy link
Member

Availability: Monday - Friday, 10:00 AM to 4:00 PM JST
ETA: Friday by 4:00 PM JST

Copy link
Member

@rogerioduenas rogerioduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Six5pAdes!

Great job with this PR!

  • The branching was done correctly.
  • Issue number was listed.
  • The PR title is descriptive of the changes.
  • Changes were made correctly in the code.
  • Changes appear correctly on the repository.
  • The PR request clearly states what was updated.

Necessary to correct!

  • In "Why did you make the changes" you should delete the lines you didn't use.
    Screenshot 2025-03-05 at 15 22 56

  • Please check the checkbox if you have reviewed this PR for CodeQL alerts and found none.

Not necessary to change, but a good improvement!

  • You can simplify the description to something like: 'Fixed a typo in file _program-areas/environment-card.yml and also in the path of file /assets/images/program-areas/environment.png, where "environment" was misspelled as "envirnoment".'

  • Since your PR doesn't make any visual changes that need to be verified, you could replace the images you attached with 'No visual changes to the website'.

Once you make these changes, your PR will be approved. Thanks for your hard work and your time!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Mar 5, 2025
@jenjenkayi jenjenkayi self-requested a review March 6, 2025 00:18
@katiejnete
Copy link
Member

Review ETA: EOD 3/5/25
Availability: 7-9 PM

Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Six5pAdes , thank you for taking on this issue.

Things you did well:

  • PR is done with the correct branch.
  • PR contains correctly formatted linked issue.
  • The changes are applicable to the issue.
  • Website is still user-friendly and links and components still work as intended.

Suggested changes

  • If there are no visual changes to the website, delete all of the script below "Screenshots of Proposed Changes To The Website" and just keep the "- No visual changes to the website"
  • Please make sure to use Docker to test changes locally at localhost:4000/program-areas and check if links and components work as intended. Then, please check off corresponding checkbox on the linked issue.

Notes:

  • Please delete spaces in the CodeQL Alerts checkbox, change from [ x ] to [x] to properly render the checked checkbox.
  • I noticed there were YAML formatting changes (removing spaces), but they were not related to the requested spelling fix. Consider keeping only the necessary changes requested from the linked issue so that the diffs do not clutter the commit history.

After making these changes, re-request a review from me. Thank you for your hard work!

@Six5pAdes Six5pAdes requested a review from katiejnete March 6, 2025 04:11
Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work @Six5pAdes , I approve this PR.

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Mar 6, 2025
@rogerioduenas
Copy link
Member

Hello @Six5pAdes!

Great job with this PR!

  • The branching was done correctly.
  • Issue number was listed.
  • The PR title is descriptive of the changes.
  • Changes were made correctly in the code.
  • Changes appear correctly on the repository.
  • The PR request clearly states what was updated.

Necessary to correct!

  • In "Why did you make the changes" you should delete the lines you didn't use.
    Screenshot 2025-03-05 at 15 22 56
  • Please check the checkbox if you have reviewed this PR for CodeQL alerts and found none.

Not necessary to change, but a good improvement!

  • You can simplify the description to something like: 'Fixed a typo in file _program-areas/environment-card.yml and also in the path of file /assets/images/program-areas/environment.png, where "environment" was misspelled as "envirnoment".'
  • Since your PR doesn't make any visual changes that need to be verified, you could replace the images you attached with 'No visual changes to the website'.

Once you make these changes, your PR will be approved. Thanks for your hard work and your time!

Thank you very much for making the corrections and for your hard work, your PR has been approved, congratulations.

@jenjenkayi
Copy link
Member

Hi @Six5pAdes,

  • the pull request was done with the correct branch
  • the pull request is linked with the correct issue
  • the changes were made correctly

Thank you for contributing and your time.

@jphamtv jphamtv merged commit 6f99e73 into hackforla:gh-pages Mar 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: spelling good first issue Good for newcomers P-Feature: Program Area https://www.hackforla.org/program-areas role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Correct misspelling in Programs Area page on environment card

5 participants