Added Angela Lee to VRMS leadership, with corrected links

[Crocodile-Lyle]

Fixes #7877

What changes did you make?

• Verified and corrected given github links to working ones -
• Added Angela Lee to the leadership variable in _projects/vrms.md

Why did you make the changes (we will use this info to test)?

• To add her profile to the leadership section webpage.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

• I have checked this PR for CodeQL alerts and none were found.
• I found CodeQL alert(s), and (select one):
  • I have resolved the CodeQL alert(s) as noted
  • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
  • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Before:

Visuals after changes are applied

After:

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b Crocodile-Lyle-update-vrms-profile-7877 gh-pages
git pull https://github.com/Crocodile-Lyle/hfla-website.git update-vrms-profile-7877

[DDVVPP]

Review ETA: 5PM March 8, 2025
Availability: 11AM - 5PM M-F

[DDVVPP]

Looks good @Crocodile-Lyle !

• The pull request is made with the correct branch
• The issue is correctly linked
• Angela has been added to projects/vrms
• Before and after images match my local and prod environments

Questions & Suggestions:

• I've left two comments about differences between the text in the referring issue and the updated text in your PR. My local environment links to the correct github handle and displays the github profile's image correctly, however I'm wondering if there was a discussion elsewhere about the change in text. I noticed that the PR indicates 'corrected links' in the title, but I feel like I've missed a step in the process!
• The branch name could be a little more descriptive i.e. added-angela-lee-to-vrms-profile

[Crocodile-Lyle]

Everything looks pretty good @Crocodile-Lyle !

• The pull request is made with the correct branch
• The issue is correctly linked
• Angela has been added to projects/vrms
• Before and after images match my local and prod environments

Question: I've left two comments about differences between the text in the referring issue and the updated text in your PR. My local environment links to the correct github handle and displays the github profile's image correctly, however I'm wondering if there was a discussion elsewhere about the change in text. I noticed that the PR indicates 'corrected links' in the title, but I feel like I've missed a step in the process!

Hello!

Yes, I should have documented what I did more clearly. The links to the github profile as well as the photo that were provided on the issue were not valid URLs. I had to find her profile on github and paste the correct URLs for the profile and photo. This is because her profile lives at 'github.com/angela-lee1/awlFCCamp' not 'github.com/awlFCCamp'.

Next time I will document my steps more clearly rather than just use a vague title.

Thank you for your review!

[DDVVPP]

@Crocodile-Lyle thanks for you feedback!
Approved! :)

[rogerioduenas]

Availability: Monday - Friday, 10:00 AM to 4:00 PM JST
ETA: Friday by 4:00 PM JST

[rogerioduenas]

Hi @Crocodile-Lyle !

Great job with this pull request!

• The branching was done correctly.
• Issue number was listed.
• The PR title is descriptive of the changes.
• Changes were made correctly in the code.
• Changes appear correctly on the site - Angela Lee was Added from VRMS page.
• Relevant images were included to show visual changes.
• The PR request clearly states what was updated.

Again, great work and thanks for taking the time to contribute to the website!

[t-will-gillis]

Hey @Crocodile-Lyle Thanks for working on this issue. A couple of notes:

• It is great that you (and @DDVVPP) noticed the discrepancy in the entry for the user. But please remember that if you see a disprepancy, it is always safest to contact the issue writer or and/or the someone on the merge team to discuss whether changes need to be made. If so you need to note the changes on the PR.

• In this case, the developer switched their GitHub handle from awlfccamp and they are now using angela-lee1 as their primary handle so this is what we want to use also.

• Also, although the picture link you provided works for this person, the link format shown below is the format we use in these entries. (And it also works of course.)

• Therefore, please correct the entry as follows:

    - name: Angela Lee
      github-handle: angela-lee1
      role: Developer
      links:
        slack: https://hackforla.slack.com/team/U062NB2CKMZ
        github: https://github.com/angela-lee1/
      picture: https://avatars.githubusercontent.com/angela-lee1
  

• Also note that a separate PR was merged while you were working on this one, and that is causing a merge conflict that needs to be resolved. It is relatively easy to address- just need to keep the new entry for Mudassir Hussain. See the instructions below and let me know if you need any help with it.

  Thanks- when you are done making changes, please select to 'Re-request review' for the three current PR reviewers.

[Crocodile-Lyle]

Hey @Crocodile-Lyle Thanks for working on this issue. A couple of notes:

• It is great that you (and @DDVVPP) noticed the discrepancy in the entry for the user. But please remember that if you see a disprepancy, it is always safest to contact the issue writer or and/or the someone on the merge team to discuss whether changes need to be made. If so you need to note the changes on the PR.
• In this case, the developer switched their GitHub handle from awlfccamp and they are now using angela-lee1 as their primary handle so this is what we want to use also.
• Also, although the picture link you provided works for this person, the link format shown below is the format we use in these entries. (And it also works of course.)
• Therefore, please correct the entry as follows:

    - name: Angela Lee
      github-handle: angela-lee1
      role: Developer
      links:
        slack: https://hackforla.slack.com/team/U062NB2CKMZ
        github: https://github.com/angela-lee1/
      picture: https://avatars.githubusercontent.com/angela-lee1
  

• Also note that a separate PR was merged while you were working on this one, and that is causing a merge conflict that needs to be resolved. It is relatively easy to address- just need to keep the new entry for Mudassir Hussain. See the instructions below and let me know if you need any help with it.
  Thanks- when you are done making changes, please select to 'Re-request review' for the three current PR reviewers.

@t-will-gillis Ok good info, thank you! I just tried to use the online GUI to resolve the merge conflict. Can you let me know if it looks good now?

[t-will-gillis]

Hi @Crocodile-Lyle Yes- looks like the merge conflict is resolved.

[rogerioduenas]

Hello @Crocodile-Lyle, are you ok? I checked your task again, and the conflict was resolved correctly, but you didn't make the requested change. Did you see that the issue was updated? You need to replace awlfccamp with angela-lee1 in several places, not just in the GitHub link. Make sure to use the correct data provided by @t-will-gillis.

    - name: Angela Lee
      github-handle: angela-lee1
      role: Developer
      links:
        slack: https://hackforla.slack.com/team/U062NB2CKMZ
        github: https://github.com/angela-lee1/
      picture: https://avatars.githubusercontent.com/angela-lee1

Observe the differences in your branch:

If you need help, you can reach out to me on Slack. :)

[siyunfeng]

@Crocodile-Lyle , please fix the issue @rogerioduenas mentioned in comment when you're available.
You can tag the reviewers in the comment or re-request them to re-review your PR once you have fixed all the changes they requested.

[t-will-gillis]

Hi @Crocodile-Lyle In case there has been confusion, this PR still has outstanding items that need to be addressed. Please see my and @rogerioduenas 's comments above and let us know if you have any questions. Thanks

[kdaca19xx]

Things Done Well

• The pull request was done with the correct branch.
• There is a linked issue.
• I understood the linked issue.
• The changes were viewable at localhost:4000/projects/vrms.
• The file changes tab shows that DDVVPP marked this issue as "resolved".

Suggested Changes

I'm new, so I didn't poke around to check for anything else, and I didn't see anything glaring.

[Crocodile-Lyle]

@rogerioduenas @t-will-gillis @siyunfeng
Thank you all for your patience! It took me a long time to figure out how to update an existing PR as using github is still very new to me. Please let me know if I have done this correctly this time?

Deleted my old changes and pasted the full snippet for Angela's profile.

Thank you!!

[t-will-gillis]

Hey @Crocodile-Lyle Thank you for making the edits (and previously fixing the merge conflict)- looks great.

[gmgonzal]

Review ETA: 3/26

[gmgonzal]

PR Reviews

Hi @Crocodile-Lyle, thank you for working on this issue. Your changes look good:

Things You Did Well:

• Step 0: PR is done with the correct branch.
  • Issue title looks good.
  • PR description looks good.
• Step 1: PR links to the correct issue #7877
• Step 2: Changes appear to address the issue action items.
• Step 3: Website page looks good on the browser.
• Step 4: Source code changes look good.
• Step 5: No other issues seen.

Well done :)

[DDVVPP]

All the changes have been made as requested! Approving again
Thanks @Crocodile-Lyle

[t-will-gillis]

Hey @rogerioduenas - since you previously approved this, I will merge this. Thanks all