-
-
Notifications
You must be signed in to change notification settings - Fork 843
Adjust timing for hiding bot comments in "Schedule Friday" workflow #8153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust timing for hiding bot comments in "Schedule Friday" workflow #8153
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Tuesdays 7-9 PM, and varying weekdays 7-9 PM |
katiejnete
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @t-will-gillis , thank you for taking on this issue.
Things you did well:
- PR is done with the correct branch.
- PR contains correctly formatted linked issue.
- CodeQL Alerts have been properly checked.
- PR follows correct format and is properly written.
- The changes are applicable to the issue.
- Source code changes are applicable and clean.
Thank you for your hard work, I approve this PR.
|
Availability: Sun 5/25/25 6-9 PM |
andyvu923
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @t-will-gillis , thanks for working on this issue!
Things done well
- PR uses correct branches
- PR links correct issue
- CodeQL is properly checked
- Source code changes are applicable and clean
LGTM, PR Approved 👍👍
Fixes #8152
What changes did you make?
sevenDayCutoffTimeso that duplicate bot comments older than 6 days 23 hours 50 minutes are hidden.Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)