Skip to content

Conversation

@t-will-gillis
Copy link
Member

@t-will-gillis t-will-gillis commented May 22, 2025

Fixes #8152

What changes did you make?

  • Adjust timing on "Schedule Friday" variable sevenDayCutoffTime so that duplicate bot comments older than 6 days 23 hours 50 minutes are hidden.

Why did you make the changes (we will use this info to test)?

  • The current workflow often leaves two bot comments open when the older comment is exactly 7 days ago, when the intent is to only have the most recent comment open.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to website.
  • Workflow logs showing successful run

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-adjust-timing-sch-friday-8152 gh-pages
git pull https://github.com/t-will-gillis/website.git adjust-timing-sch-friday-8152

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 1pt Can be done in 4-6 hours Lang: GHA GitHub Actions labels May 22, 2025
@katiejnete katiejnete self-requested a review May 23, 2025 01:44
@katiejnete
Copy link
Member

Availability: Tuesdays 7-9 PM, and varying weekdays 7-9 PM
ETA: Today EOD

Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @t-will-gillis , thank you for taking on this issue.

Things you did well:

  • PR is done with the correct branch.
  • PR contains correctly formatted linked issue.
  • CodeQL Alerts have been properly checked.
  • PR follows correct format and is properly written.
  • The changes are applicable to the issue.
  • Source code changes are applicable and clean.

Thank you for your hard work, I approve this PR.

@andyvu923
Copy link
Member

Availability: Sun 5/25/25 6-9 PM
ETA: 5/23/25 EOD

Copy link
Member

@andyvu923 andyvu923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @t-will-gillis , thanks for working on this issue!

Things done well

  • PR uses correct branches
  • PR links correct issue
  • CodeQL is properly checked
  • Source code changes are applicable and clean

LGTM, PR Approved 👍👍

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 23, 2025
@t-will-gillis t-will-gillis merged commit c64999c into hackforla:gh-pages May 25, 2025
9 checks passed
@t-will-gillis t-will-gillis deleted the adjust-timing-sch-friday-8152 branch May 25, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Projects

Development

Successfully merging this pull request may close these issues.

Adjust timing for hiding bot comments in "Schedule Friday" workflow

3 participants