Update Project Profile: Civic Tech Jobs- Remove Ida Valenzuela #8154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to PR Needs review
in P: HfLA Website: Project Board
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
Member
|
Availability: Weekdays after 7pm |
sandavid11
approved these changes
May 23, 2025
Member
sandavid11
left a comment
sandavid11
left a comment
There was a problem hiding this comment.
Great job with the PR
- PR made from correct branch
- Linked issue included
- Before and after images included
PR approved. Thank you!
t-will-gillis
requested changes
May 23, 2025
Member
There was a problem hiding this comment.
Hey @kevinashworth Great job-
- Branches 'from' and 'to' look good
- Issue is linked
- There were no CodeQL alerts
- There are relevant 'before' and 'after' screenshots attached (bonus for identifying the profile to be deleted)
- The code edits are clean
A couple of (minor) comments:
- The response for "What changes did you make?" is fine. You could be a little more specific, i.e. "Removed Ida Valenzuela's profile from the CTJ project"
- For "Why did you make the changes?", the response is intended to be the reason why the issue was needed. This info is from the original issue's "Overview", so in this case the response should be something short along the lines of "To keep the website information up to date."
- Please check off the relevant "Action Items" in the original issue.
Thanks for working on this!
github-project-automation
bot
moved this from PR Needs review
to PRs being reviewed
in P: HfLA Website: Project Board
Member
Author
|
@t-will-gillis -- I made the requested changes
|
github-project-automation
bot
moved this from PRs being reviewed
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7996
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied