Skip to content

Refactor minimizeIssueComments() to Avoid Limit #8155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-will-gillis merged 4 commits into from
May 25, 2025
Merged

Refactor minimizeIssueComments() to Avoid Limit #8155

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9b14ff
Schedule Friday 0700
katiejnete May 23, 2025
55a5780
Schedule Friday 0700
katiejnete May 23, 2025
bd25417
Limit bot comment hiding to 7–30 day window to reduce GraphQL calls
katiejnete May 23, 2025
4c60537
Refactor cutoff time logic for consistency and readability
katiejnete May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions github-actions/trigger-schedule/add-update-label-weekly/add-label.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,16 @@ const [
const updatedByDays = 3; // If last update update 3 days, the issue is considered updated
const commentByDays = 7; // If last update between 7 to 14 days ago, issue is outdated and needs update
const inactiveUpdatedByDays = 14; // If last update greater than 14 days ago, the issue is considered inactive
const upperLimitDays = 30; // Bot-generated comments older than this are not checked by minimizeComments()

const threeDayCutoffTime = new Date();
threeDayCutoffTime.setDate(threeDayCutoffTime.getDate() - updatedByDays);
const sevenDayCutoffTime = new Date();
sevenDayCutoffTime.setDate(sevenDayCutoffTime.getDate() - commentByDays);
const fourteenDayCutoffTime = new Date();
fourteenDayCutoffTime.setDate(fourteenDayCutoffTime.getDate() - inactiveUpdatedByDays);
const upperLimitCutoffTime = new Date();
upperLimitCutoffTime.setDate(upperLimitCutoffTime.getDate() - upperLimitDays);



Expand Down Expand Up @@ -184,8 +187,8 @@ function isTimelineOutdated(timeline, issueNum, assignees) { // assignees is an
lastAssignedTimestamp = eventTimestamp;
}

// If this event is more than 7 days old AND this event is a comment by the GitHub Actions Bot, then hide the comment as outdated.
if (!isMomentRecent(eventObj.created_at, sevenDayCutoffTime) && eventType === 'commented' && isCommentByBot(eventObj)) {
// If this event is more than 7 days old but less than the upperLimitCutoffTime AND this event is a comment by the GitHub Actions Bot, then hide the comment as outdated.
if (isMomentRecent(eventObj.created_at, upperLimitCutoffTime) && !isMomentRecent(eventObj.created_at, sevenDayCutoffTime) && eventType === 'commented' && isCommentByBot(eventObj)) {
console.log(`Comment ${eventObj.node_id} is outdated (i.e. > 7 days old) and will be minimized.`);
commentsToBeMinimized.push(eventObj.node_id); // retain node id so its associated comment can be minimized later
}
Expand Down