Skip to content

Conversation

@eunicode
Copy link
Member

@eunicode eunicode commented May 23, 2025

Fixes #7998

What changes did you make?

  • Add Giselle Dizon's profile after the last Team Lead profile on the Expunge Assist project page

Why did you make the changes (we will use this info to test)?

  • To update the Expunge Assist project page

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied before
Visuals after changes are applied after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b eunicode-add-profile-expunge-assist-7998 gh-pages
git pull https://github.com/eunicode/hflawebsite.git add-profile-expunge-assist-7998

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 23, 2025
@DakuwoN DakuwoN self-requested a review May 24, 2025 00:02
@DakuwoN
Copy link
Member

DakuwoN commented May 24, 2025

Review ETA: 6 PM 5/24/25 (Tomorrow evening)
Availability: 11-2CST PM M-Sat

@kdaca19xx kdaca19xx self-requested a review May 24, 2025 02:08
Copy link
Member

@DakuwoN DakuwoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks perfect, great job, thank you for contributing!

@kdaca19xx
Copy link
Member

Availability: Mon-Fri after 1pm (pacific)
ETA: 5/26

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job, eunicode!

Things Done Well

  • Pull request done with the correct branch.
  • There's a linked issue, and I understand it.
  • The changes in the Files Changed tab look good, including the slack and GitHub URLs.
  • I viewed the changes in the browser.

Suggestions

none.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 27, 2025
@daras-cu daras-cu merged commit 05bddcb into hackforla:gh-pages May 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist- Add Giselle Dizon

4 participants