Skip to content

Conversation

@ryanfkeller
Copy link
Member

@ryanfkeller ryanfkeller commented May 25, 2025

Fixes #7954

What changes did you make?

  • Added Jon Ilaw to the project team on the Home Unite Us page by adding his information to the home-unite-us.md leadership variable after other UI/UX designers.

Why did you make the changes (we will use this info to test)?

  • Change needed to keep the Home Unite Us project team information up to date.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied image
Visuals after changes are applied image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b ryanfkeller-home-unite-us-add-jon-ilaw-7954 gh-pages
git pull https://github.com/ryanfkeller/website.git home-unite-us-add-jon-ilaw-7954

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 25, 2025
@ryanfkeller ryanfkeller marked this pull request as ready for review May 25, 2025 17:11
@kdaca19xx kdaca19xx self-requested a review May 25, 2025 18:43
@kdaca19xx
Copy link
Member

Availability: Mon-Fri after 1pm (pacific)
ETA: 5/26

@sandavid11 sandavid11 self-requested a review May 26, 2025 04:19
@sandavid11
Copy link
Member

Availability: Weekdays after 7 pm (pacific)
ETA: 5/26

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done, ryanfkeller!

Things Done Well

  • The pull request is done with the correct branch.

  • There's a linked issue, and I understand it.

  • The changes in the Files Changed tab look good, including the slack and GitHub URLs.

  • I viewed the changes in the browser.

Suggestions

none.

Copy link
Member

@sandavid11 sandavid11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ryanfkeller thanks for taking on this issue.

Things done well

  • PR was made from correct branch
  • Linked issue included
  • Action Items checked off on issue
  • Before and after images included

Great job on the PR. Approved!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 27, 2025
@daras-cu daras-cu merged commit d292613 into hackforla:gh-pages May 28, 2025
9 checks passed
@ryanfkeller ryanfkeller deleted the home-unite-us-add-jon-ilaw-7954 branch June 4, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Home Unite Us Add Jon Ilaw

4 participants