-
-
Notifications
You must be signed in to change notification settings - Fork 843
Add Jon Ilaw to Home Unite Us Page #8159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jon Ilaw to Home Unite Us Page #8159
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Mon-Fri after 1pm (pacific) |
|
Availability: Weekdays after 7 pm (pacific) |
kdaca19xx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this done, ryanfkeller!
Things Done Well
-
The pull request is done with the correct branch.
-
There's a linked issue, and I understand it.
-
The changes in the Files Changed tab look good, including the slack and GitHub URLs.
-
I viewed the changes in the browser.
Suggestions
none.
sandavid11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ryanfkeller thanks for taking on this issue.
Things done well
- PR was made from correct branch
- Linked issue included
- Action Items checked off on issue
- Before and after images included
Great job on the PR. Approved!
Fixes #7954
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied