-
-
Notifications
You must be signed in to change notification settings - Fork 843
Added Ligertwood to Expunge Assist's project page #8160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Ligertwood to Expunge Assist's project page #8160
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Weekdays after 5 |
sandavid11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things done well
- PR was made from the correct branch
- Included linked to issue
- Before and after images show the changes made
- Only the file requested by issue was change
Great job with the PR!
|
Availability: Weekdays 12p to 5p |
ryanfkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @caz002,
Nice job! I'm well agreed with @sandavid11:
- The PR is to/from the correct branches
- Your changes address the linked issue as it is written (and nailed putting the profile location exactly as the issue requested
☺️ ) - Your PR description accurately describes what you did and includes before/after pictures
- The change didn't trip any auto-checks
Approved! Thanks!
|
Hi @caz002, this PR has a merge conflict because another member was just added to the same file in the same spot. Please resolve the conflict by keeping both new additions. You can either use Github's editor by choosing "Resolve conflicts" below or use your local editor--see here for more info. Thanks! |
|
Thanks @caz002, I reviewed the changes after you resolved the conflict and everything looks good. |
|
Ok great, thanks for reviewing! |
Fixes #7999
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied