Skip to content

Conversation

@caz002
Copy link
Member

@caz002 caz002 commented May 26, 2025

Fixes #7999

What changes did you make?

  • added Ligertwood to the Current Project Team section of Expunge Assist's project page

Why did you make the changes (we will use this info to test)?

  • To keep list of project team members up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied before
Visuals after changes are applied after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b caz002-update-project-profile-add-ligertwood-7999 gh-pages
git pull https://github.com/caz002/website.git update-project-profile-add-ligertwood-7999

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 26, 2025
@sandavid11 sandavid11 self-requested a review May 27, 2025 04:21
@sandavid11
Copy link
Member

Availability: Weekdays after 5
ETA: 5/27

sandavid11
sandavid11 previously approved these changes May 27, 2025
Copy link
Member

@sandavid11 sandavid11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things done well

  • PR was made from the correct branch
  • Included linked to issue
  • Before and after images show the changes made
  • Only the file requested by issue was change

Great job with the PR!

@ryanfkeller ryanfkeller self-requested a review May 27, 2025 19:57
@ryanfkeller
Copy link
Member

Availability: Weekdays 12p to 5p
Initial Review ETA: 5/27/2025

ryanfkeller
ryanfkeller previously approved these changes May 27, 2025
Copy link
Member

@ryanfkeller ryanfkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @caz002,

Nice job! I'm well agreed with @sandavid11:

  • The PR is to/from the correct branches
  • Your changes address the linked issue as it is written (and nailed putting the profile location exactly as the issue requested ☺️)
  • Your PR description accurately describes what you did and includes before/after pictures
  • The change didn't trip any auto-checks

Approved! Thanks!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 27, 2025
@daras-cu
Copy link
Member

Hi @caz002, this PR has a merge conflict because another member was just added to the same file in the same spot. Please resolve the conflict by keeping both new additions. You can either use Github's editor by choosing "Resolve conflicts" below or use your local editor--see here for more info. Thanks!

@caz002 caz002 dismissed stale reviews from ryanfkeller and sandavid11 via b64b219 May 28, 2025 02:34
@daras-cu
Copy link
Member

Thanks @caz002, I reviewed the changes after you resolved the conflict and everything looks good.

@daras-cu daras-cu merged commit b99331d into hackforla:gh-pages May 28, 2025
3 checks passed
@caz002
Copy link
Member Author

caz002 commented May 28, 2025

Ok great, thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist- Add Melissa Ligertwood

4 participants