Updated Expunge Assist- changed role Rachel Ichniowski

[sarahgraup]

Fixes #8000

What changes did you make?

• Changed role for Rachel Ichniowski in project Expunge Assist

Why did you make the changes (we will use this info to test)?

• To keep Expunge Assist project profiles up-to-date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

• I have checked this PR for CodeQL alerts and none were found.
• I found CodeQL alert(s), and (select one):
  • I have resolved the CodeQL alert(s) as noted
  • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
  • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Visuals after changes are applied

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b sarahgraup-update-project-profile-8000 gh-pages
git pull https://github.com/sarahgraup/website.git update-project-profile-8000

[hoanhua14]

Hi @sarahgraup , thank you for working on this issue. Your code changes look good but there are a few changes needed:
Things you did well:

• PR is done with the correct branch
• Website page looks good on different viewports
• Changes appear to address the issue action items

Things to change:

• There's a merge conflict to be resolved
• For the second question (Why did you make the changes ?), it's usually the reason for the edit, such as: to keep the page updated.
• CodeQL section is not checked
• Last checkbox in the action item list is not checked

I'm also curious about the code change which I'm hoping you can help to clarify. There were 7 lines removed and 7 lines added but I don't see removal mentioned in the action items.
I'll approve once changes are made. Thank you!

[katiejnete]

Availability: Varying weekdays, 7-9pm
ETA: EOD

[katiejnete]

Hi @sarahgraup , thank you for taking on this issue.

Things you did well:

• PR is done with the correct branch.
• PR contains correctly formatted linked issue.
• Website is still user-friendly and links and components still work as intended.

Suggested changes:

• Please check for CodeQL Alerts and check the corresponding checkbox.
• It looks like the 'before' and 'after' screenshots were accidentally switched. The image labeled 'before' is actually the 'after,' and vice versa. Please switch the screenshots.
• I noticed that the old project profile lines were deleted and the updated ones were added above Sydney Walcoff’s project profile. As per the action items, the updated project profile lines should be added after the last Product Manager, following Rick Peng’s project profile instead.
• Please change “Why did you make the changes (we will use this info to test)?” section to something like “To keep Expunge Assist project profiles up-to-date.”
• Please resolve the merge conflict.

After making these changes, re-request a review from me. Thank you for your hard work!

[ryanfkeller]

Review Availability: Weekdays 12-5p
ETA: TBD (likely +1 day to when other changes are addressed)

Thanks for taking this issue @sarahgraup!

I've taken a look through your PR already and largely agree with @hoanhua14 and @katiejnete (except to me the before and after screenshots look to be accurately ordered based on the code changes). I did see that there was a previously completed issue (#7702) that also tackled adding Rachel Ichniowski to this page, so I think you took the correct approach of updating their info rather than just adding them in again as a duplicate team member.

I don't have additional changes to request other than what your other reviewers have suggested, so I'll hold off on marking this as "needs changes" so I don't become another blocker on things they already caught! When you make your update, I'll take another look.

Thanks again!

[ryanfkeller]

Hi @sarahgraup,

I'm still seeing a merge conflict on this PR. You'll need to resolve that before your changes can be pulled into gh-pages. Check out HfLA's section on dealing with merge conflicts here: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#31d-dealing-with-merge-conflicts.

To my eye it looks like you've addressed all the other items, so once you sort out the merge conflict, this PR should be good to go! Thank you!

[t-will-gillis]

Hi @sarahgraup

I inserted myself into your issue because the original issue (that I wrote) says to add Rachel Ichniowski's profile to the project. However, Rachel's profile already exists, so the issue should have been only to change Rachel Ichniowski's role: from:

role: Product Manager, UX Research  

to:

role: Product Manager, UX Research and Content

Since this was my bad, and since I did not want this to become too complicated for your first issue: I made that edit to the original issue, and I resolved the merge conflict to show the correct edit.

Please:

• change the title of this PR to something like "Updated Expunge Assist- changed role Rachel Ichniowski"
• change "What changes did you make?" to something similar "Changed role for Rachel Ichniowski in project Expunge Assist"
• for "Why did you make the changes?", the answer is good. Just add a space between the '-' and "To keep Expunge Assist project profiles up-to-date". Then the formatting will be corrected.
• I am OK with your 'before' and 'after' screenshots, but feel free to swap in a new 'after' shot

Apologies for the confusion! Let us know if you need any help.

[t-will-gillis]

@ryanfkeller @hoanhua14 @katiejnete FYI there was a mistake on the original issue, so please see the notes above.

[katiejnete]

These changes look good to me. Thank you for your hard work. I approve this PR.

[ryanfkeller]

Agreed -- all looks good! Thanks for the help and feedback all!

• PR currently has two approvals.
• It appears that all of the reviewers' comments have been addressed. Dismissing to facilitate approval and merging.