Skip to content

Conversation

@ariellockett2
Copy link
Member

@ariellockett2 ariellockett2 commented Jun 4, 2025

Fixes #7548

What changes did you make?

  • Removed Anna Kim from the 311 Data current project team
  • This included a profile picture, name, role, GitHub handle, and links to Anna's Slack and GitHub
  • Made changes in the leadership section of the front matter block of the _projects/311-data.md file

Why did you make the changes (we will use this info to test)?

  • To ensure the list of current project team members is up-to-date for the 311 Data project

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Screenshot 2025-06-03 at 8 04 55 PM
Visuals after changes are applied Screenshot 2025-06-03 at 8 07 42 PM

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 4, 2025
@github-actions
Copy link

github-actions bot commented Jun 4, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b ariellockett2-update-project-profile-7548 gh-pages
git pull https://github.com/ariellockett2/website.git update-project-profile-7548

@katiejnete katiejnete self-requested a review June 4, 2025 02:21
@katiejnete
Copy link
Member

Availability: Varying weekdays 7-9PM
ETA: EOD

Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ariellockett2 , thank you for taking on this issue.

Things you did well:

PR is done with the correct branch.
PR contains correctly formatted linked issue.
CodeQL Alerts have been properly checked.
Before and after screenshots are appropriately included.
PR follows correct format and is properly written.
The changes are applicable to the issue.
Website is still user-friendly and links and components still work as intended.
Source code changes are applicable and clean.

Suggested changes:

None

Thank you for your hard work, I approve this PR.

@caz002 caz002 self-requested a review June 4, 2025 04:02
@caz002
Copy link
Member

caz002 commented Jun 4, 2025

Review ETA: 6/4/2025
Availability: 2-8 PM

Copy link
Member

@caz002 caz002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the PR!

Things done well

  • Pull request description and photos are clear and accurately describe changes
  • Issue is linked in PR
  • Only the file requested by the issue was changed
  • PR has no CodeQL alerts or unresolved merge conflicts

Suggested changes

  • None

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Jun 4, 2025
@mugdhchauhan
Copy link
Member

Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉

@mugdhchauhan mugdhchauhan merged commit 7073f1d into hackforla:gh-pages Jun 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: 311 Data Remove Anna Kim

4 participants