Add github-handle for Emily F. in public-tree-map.md

[Jeffreyp1]

Fixes #7792

What changes did you make?

• I added "github-handle" on public-tree-map.mdd

Why did you make the changes (we will use this info to test)?

• To allow the HFLA website to display the github handle of the team leader

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

• I have checked this PR for CodeQL alerts and none were found.
• I found CodeQL alert(s), and (select one):
  • I have resolved the CodeQL alert(s) as noted
  • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
  • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual change to the website

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b Jeffreyp1-add-github-handle gh-pages
git pull https://github.com/Jeffreyp1/hackforla.git add-github-handle

[kevinashworth]

Hey @Jeffreyp1

There are a few things about this that need to be modified. It's not about the code change that you made, as that looks good! These things are about this pull request itself here on GitHub, focusing on the title and the text in the first box at the top of this PR.

Here are some things to do:

• The title of the PR would be better as a copy/paste of the original issue, or in least in some way include Emily F and public tree map.
• The first paragraph that starts with Please note is not necessary, and could be removed. That would leave this PR starting with Fixes ...
• Also, in the place where it says Fixes #replace_this_text_with_the_issue_number you would need to put Fixes #7792. The number comes from the original issue, Add github-handle for Emily F. in public-tree-map.md #7792 .
• (When a new PR references the issue number that way, an automated process will attach tags to the PR from the issue. You'll notice that the original issue has 5 tags, including good first issue. They should all appear on this PR too. I do not know if that process will kick in now upon your edit. I hope it does! If not, please add the tags manually.)
• Offer answers to the What and Why questions. Short, simple answers are fine. No need to provide 3 answers just because there are 3 bullet points. The Why question could be answered simply as To prepare the website with a place to show the github handle for each team leader., or something like that..
• The Screenshots are not showing up. I'm seeing a broken-image icon. Please re-edit to include those.

I'm more than happy to answer questions or help you through this. You can message me on the HfLA Slack or reply here.

Thanks for working on this!

[kevinashworth]

The code looks great! There are some problems with the creation of the Pull Request itself, however. Please see comments on the main body of the PR.

[ryanfkeller]

Hi @Jeffreyp1,

Thanks for making some updates to this PR! The code changes look good to me as well, and you've addressed almost everything that @kevinashworth requested for PR format and clarity.

The only thing I noticed that you missed is the "screenshots" portion. It looks to me like you've left in the placeholder text in the URL that makes it look to reviewers like your images are broken.

My expectation is that your code change does not result in a visual change to the website, so I would recommend removing the "Visuals before changes" and "Visuals after changes" sections, and just put the text "No visual change to the website" under the Screenshots header. Should be a quick fix, and I'm ready to approve right after you make it.

Thanks again for contributing!

[t-will-gillis]

Hey @Jeffreyp1 This PR is almost completed but @kevinashworth and @ryanfkeller have noted a couple of items that need to be resolved. Could you give us an eta for when you are planning to complete this? Thanks!

[daras-cu]

Hi @Jeffreyp1, it looks like you may have made the requested changes to this PR, if so please re-request a review from your two reviewers so they know to come back and re-check. If you still have more to do, please let us know an ETA for when you will be finished.

[LRenDO]

Hi @Jeffreyp1!

As @daras-cu mentioned, it looks like you made all the changes and it's ready for another look by the reviewers. You can re-request a review by clicking the circle with the arrows in next to the reviewers handles in the "Reviewers" section at the top of the page to the right of the PR.

Let me know if you need any help!

[myronchen-git]

Good job.

• The merge from and to branches are correct.
• The issue is linked correctly.
• The reason given for the pull request could be better. While the GitHub handle will be used to render the GitHub profile link and picture, the main reason is to reduce redundancy. See the overview statement in the linked issue.

[ryanfkeller]

Thanks for the updates @Jeffreyp1. I'm agreed with @myronchen-git's points, and also agree this looks ready to roll. Approved

[mugdhchauhan]

Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge as there are two approving reviews. 🎉

inactive