Skip to content

fix(toolkit): prevent "?" from being appended to URL when no filters are active #8180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-will-gillis merged 1 commit into from
Jun 22, 2025
Merged

fix(toolkit): prevent "?" from being appended to URL when no filters are active #8180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions assets/js/toolkit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,17 +248,15 @@ function applyFilters(filtersParams) {

// Apply current filters to URL
function applyFiltersToURL(filterParams) {
let filters = ''
for (let key in filterParams) {
if (filterParams[key].length) {
filters = filters + `${key}=${filterParams[key].join(',')}&`
}
}
// Remove extra &
if (filters) {
filters = filters.slice(0, filters.length - 1)
const url = new URL(window.location)
const params = new URLSearchParams()

for (const [key, values] of Object.entries(filterParams)) {
values.forEach(value => params.append(key, value))
}
window.history.replaceState(null, '', `?${filters}`)

url.search = params.toString()
window.history.replaceState(null, '', url)
}

// Apply URL to filters
Expand Down