-
-
Notifications
You must be signed in to change notification settings - Fork 843
Refactored GHA Code for issue-trigger.yml
#8181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored GHA Code for issue-trigger.yml
#8181
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
t-will-gillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @xnealcarson Looks great!
- Branches are good
- Issue is linked
- There are good descriptions of what is changing and why
- A test run is linked
- No visual changes
Everything looks great- please delete issue-trigger2.yml and this is good to go!
|
Hey @t-will-gillis . I've gone ahead and deleted |
t-will-gillis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks @xnealcarson !
santiseccovidal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xnealcarson
Everything looks great. Branches and code changes are correct, I also run the changes in my own repo and it works as expected. Check it here
The explanation of the What and Why sections are clear and descriptive.
Thanks for working on this.
Fixes #8151
What changes did you make?
tspascoal/get-user-teams-membershipwith our existing, internalcheck-team-membership.jsmodule within theissue-trigger.ymlfile,issue-trigger2.ymlin order to enable the GitHub Action (GHA)Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)