Skip to content

Conversation

@xnealcarson
Copy link
Member

@xnealcarson xnealcarson commented Jun 11, 2025

Fixes #8151

What changes did you make?

  • Refactored the issue-trigger.yml file to replace the external tspascoal/get-user-teams-membership with our existing, internal check-team-membership.js module within the
  • Made a copy of the issue-trigger.yml file, issue-trigger2.yml in order to enable the GitHub Action (GHA)
  • Test triggered the GHA is by opening a new issue within my own repo. (Test Issue link: Test Issue xnealcarson/website#14)

Why did you make the changes (we will use this info to test)?

  • We already have the check-team-membership.js utility, so we should use it.
  • With the external module, we are relying on someone outside of the organization to keep the code current.
  • If we use the internal utility function, we are able to eliminate the TEAMS secret & TEAMS token.
  • Reorder of the workflow steps so that team membership is checked first since this is the controlling step.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b xnealcarson-replace-external-gha-module-8151 gh-pages
git pull https://github.com/xnealcarson/website.git replace-external-gha-module-8151

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 3pt Can be done in 13-18 hours Lang: GHA GitHub Actions labels Jun 11, 2025
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xnealcarson Looks great!

  • Branches are good
  • Issue is linked
  • There are good descriptions of what is changing and why
  • A test run is linked
  • No visual changes

Everything looks great- please delete issue-trigger2.yml and this is good to go!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Jun 13, 2025
@katiejnete katiejnete requested review from katiejnete and removed request for katiejnete June 14, 2025 00:35
@xnealcarson
Copy link
Member Author

Hey @t-will-gillis . I've gone ahead and deleted issue-trigger2.yml.

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks @xnealcarson !

@santiseccovidal santiseccovidal self-requested a review June 15, 2025 17:37
Copy link
Member

@santiseccovidal santiseccovidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xnealcarson
Everything looks great. Branches and code changes are correct, I also run the changes in my own repo and it works as expected. Check it here

The explanation of the What and Why sections are clear and descriptive.

Thanks for working on this.

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Jun 16, 2025
@t-will-gillis t-will-gillis merged commit 4a995e9 into hackforla:gh-pages Jun 16, 2025
3 checks passed
@xnealcarson xnealcarson deleted the replace-external-gha-module-8151 branch October 3, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours

Projects

Development

Successfully merging this pull request may close these issues.

Replace external GHA module with internal check-team-membership.js utility

3 participants