Refactored GHA Code for issue-trigger.yml #8181
Merged
t-will-gillis merged 4 commits intohackforla:gh-pagesfrom Jun 16, 2025
Merged
Refactored GHA Code for issue-trigger.yml #8181t-will-gillis merged 4 commits intohackforla:gh-pagesfrom
issue-trigger.yml #8181t-will-gillis merged 4 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
t-will-gillis
requested changes
Jun 13, 2025
Member
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @xnealcarson Looks great!
- Branches are good
- Issue is linked
- There are good descriptions of what is changing and why
- A test run is linked
- No visual changes
Everything looks great- please delete issue-trigger2.yml and this is good to go!
Member
Author
|
Hey @t-will-gillis . I've gone ahead and deleted |
t-will-gillis
approved these changes
Jun 15, 2025
Member
t-will-gillis
left a comment
There was a problem hiding this comment.
Awesome thanks @xnealcarson !
santiseccovidal
approved these changes
Jun 16, 2025
Member
santiseccovidal
left a comment
There was a problem hiding this comment.
Hi @xnealcarson
Everything looks great. Branches and code changes are correct, I also run the changes in my own repo and it works as expected. Check it here
The explanation of the What and Why sections are clear and descriptive.
Thanks for working on this.
2 tasks
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8151
What changes did you make?
tspascoal/get-user-teams-membershipwith our existing, internalcheck-team-membership.jsmodule within theissue-trigger.ymlfile,issue-trigger2.ymlin order to enable the GitHub Action (GHA)Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)