Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Hi @praytoo, thanks for contributing! I see that you already have PR #8197 out to address issue #8010. As you might see on the comments on that issue (here), devs are typically only permitted to take on a single issue at a time. To help the team keep track of who is working on what and avoid duplicating work, please only submit fixes for issues that you are assigned to -- and be sure to finish the issue you've got before picking up another one! Thank you for being eager to add fixes to the site! Once you've got your first GFI merged, you'll be able to help out by reviewing other PRs in parallel to your dev efforts. |
|
Okay my apologies won't happen again...should I continue with this one until it's closed or just focus on my pull request #8197? |
|
No problem! My recommendation is definitely to focus on your other PR. For this PR, you can either convert to a draft to show it shouldn't be reviewed quite yet, or delete it just in case someone else picks up #8014 before you get there. |
|
Okay @ryanfkeller ive gone ahead and deleted it to give someone else the opportunity to work on it. Thanks for your help |
Fixes #r8014
What changes did you make?
leadershipsection of_projects/311-data.md, following the instructions in issue Update Project Profile: 311 Data Add Audreen Fune #8014.Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)