Skip to content

Conversation

@santi-jose
Copy link
Member

@santi-jose santi-jose commented Jun 25, 2025

Fixes #8011

What changes did you make?

  • Added Tracy Nguyen profile data into the leadership variable of 311-data markdown file.

Why did you make the changes (we will use this info to test)?

  • Made these changes to keep 311 Data leadership list up to date for visitors.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

add-tracy-nguyen-8011_before

Visuals after changes are applied

add-tracy-nguyen-8011_after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b santi-jose-add-tracy-nguyen-8011 gh-pages
git pull https://github.com/santi-jose/website.git add-tracy-nguyen-8011

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 25, 2025
@FatCatLikesBeer FatCatLikesBeer self-requested a review June 25, 2025 21:36
@FatCatLikesBeer
Copy link
Member

Availability: Mon-Sat after 6pm PST
ETA: 6/25/2025 - EOD

Copy link
Member

@FatCatLikesBeer FatCatLikesBeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @santi-jose Thank you for taking on this issue!

Things Done Well

  • Pull request is done with the correct branch
  • Branch is properly named
  • Issue is linked and understandable
  • CodeQL Alerts have been properly recorded in PR post.
  • Appropriate changes made in the Files changed tab.
  • Before and after screenshots are included
  • Website still functions correctly
  • No spelling errors.

Requested Changes

  • None

Everything looks great, thank you for your hard work 💪🏽 I approve this PR.

@caz002
Copy link
Member

caz002 commented Jun 26, 2025

Availability: Mon-Fri after 2pm PST
ETA: 6/26/25

Copy link
Member

@caz002 caz002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job working on this issue @santi-jose !

Things done well

  • Pull request clearly explains changes and reason for making them
  • Code passes pipeline and does not trigger CodeQL alerts, CodeQL box is checked
  • Pull request includes pictures that explain changes
  • Only the file requested by the issue is changed

Changes Requested

None

I approved this pull request.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Jun 26, 2025
@mugdhchauhan
Copy link
Member

Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉

@mugdhchauhan mugdhchauhan merged commit 3a1fabe into hackforla:gh-pages Jun 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: 311 Data Add Tracy Nguyen

4 participants