Skip to content

Conversation

@dvernon5
Copy link
Member

@dvernon5 dvernon5 commented Jun 27, 2025

Fixes #5472

What changes did you make?

  • Created two new fields to store LinkedIn and GitHub handle names (not full URLs).
  • Updated the Response and Review Google Sheets to include and populate these new fields.
  • Modified the wins-data.json feed to include the extracted handle names for LinkedIn and GitHub

Why did you make the changes (we will use this info to test)?

  • To separate the raw handle data from the full URL, allowing for cleaner data management and more flexibility in display logic.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Wins-Page-Before-Testing

Visuals after changes are applied

Wins-Page-After-Testing

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b dvernon5-create-new-wins-fields-for-response-and-review-sheet-5472 gh-pages
git pull https://github.com/dvernon5/website.git create-new-wins-fields-for-response-and-review-sheet-5472

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Large P-Feature: Wins Page https://www.hackforla.org/wins/ size: 3pt Can be done in 13-18 hours labels Jun 27, 2025
@daras-cu daras-cu marked this pull request as draft June 28, 2025 17:25
@daras-cu daras-cu marked this pull request as ready for review September 22, 2025 23:55
Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested these changes and updated the code in the HackforLA Apps Script. The changes are ready to be merged into the GitHub codebase.

@daras-cu daras-cu merged commit ea65399 into hackforla:gh-pages Sep 22, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Large P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add new fields to WINS Display Review and _wins-data.json

2 participants