Skip to content

Conversation

@praytoo
Copy link
Member

@praytoo praytoo commented Jun 28, 2025

Fixes #7380

What changes did you make?

  • Added GitHub handle for Will Gillis in _projects/website.md

Why did you make the changes (we will use this info to test)?

  • to create a single variable github-handle to hold the github handle for each member of the leadership team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b praytoo-add-will-gillis-github-handle gh-pages
git pull https://github.com/praytoo/website.git add-will-gillis-github-handle

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 28, 2025
@santiseccovidal
Copy link
Member

Review ETA: 2 PM 6/29/25
Availability: 10-4 PM Sunday

@kdaca19xx
Copy link
Member

kdaca19xx commented Jun 29, 2025

Availability: after 1pm (pacific)
ETA: 6/30

Copy link
Member

@santiseccovidal santiseccovidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @praytoo the what and why sections are correct, also branches are good but the code changes need to be modified because you need to add the variable but not the GitHub handle.
Let me know if you understand what I mean, just remove t-will-gillis from the code and it will be correct.
Thanks for working on this.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Jun 29, 2025
@praytoo
Copy link
Member Author

praytoo commented Jun 29, 2025

hi @santisecco I've made the requested changes — the github-handle variable is now present but left empty. Thank you for your help!

Copy link
Member

@santiseccovidal santiseccovidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praytoo now the changes are correct. Also the docker version of the website is unchanged.
Thanks for working on this.

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts, praytoo!

Things Done Well

  • The pull request done with the correct branch.

  • There's a linked issue, and I understood it.

  • I appreciate you adding the file name under "What changes did you make?" even though it's in the Files Changed tab.

  • The change in the Files Changed tab look good!

Suggestions

I don't know if it matters because @santisecco didn't bring it up, but nothing's been checked in the CodeQL Alerts section. That said, I'd like to approve.

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Jun 30, 2025
@praytoo
Copy link
Member Author

praytoo commented Jul 1, 2025

Thank you @santisecco @kdaca19xx i adjusted the codeQL alerts section

@t-will-gillis t-will-gillis merged commit 80cdc19 into hackforla:gh-pages Jul 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Will Gillis in _projects/website.md

4 participants