-
-
Notifications
You must be signed in to change notification settings - Fork 844
Add GitHub handle for Will Gillis #8235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub handle for Will Gillis #8235
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 2 PM 6/29/25 |
|
Availability: after 1pm (pacific) |
santiseccovidal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @praytoo the what and why sections are correct, also branches are good but the code changes need to be modified because you need to add the variable but not the GitHub handle.
Let me know if you understand what I mean, just remove t-will-gillis from the code and it will be correct.
Thanks for working on this.
|
hi @santisecco I've made the requested changes — the github-handle variable is now present but left empty. Thank you for your help! |
santiseccovidal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@praytoo now the changes are correct. Also the docker version of the website is unchanged.
Thanks for working on this.
kdaca19xx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts, praytoo!
Things Done Well
-
The pull request done with the correct branch.
-
There's a linked issue, and I understood it.
-
I appreciate you adding the file name under "What changes did you make?" even though it's in the Files Changed tab.
-
The change in the Files Changed tab look good!
Suggestions
I don't know if it matters because @santisecco didn't bring it up, but nothing's been checked in the CodeQL Alerts section. That said, I'd like to approve.
|
Thank you @santisecco @kdaca19xx i adjusted the codeQL alerts section |
Fixes #7380
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
No visual changes to the website