-
-
Notifications
You must be signed in to change notification settings - Fork 843
Removed Allison Jeon in 311 data page #8236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Allison Jeon in 311 data page #8236
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Mon-Sat after 6pm PST |
|
Availability: Weekdays from 7AM to 11AM PST |
FatCatLikesBeer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Patdabaker, thank you for taking on this issue!
Things Done Well
- Pull request is done in the correct branch
- Issue is properly linked and understandable
- Issue appears to be done with the correct branch
- Appropriate changes reflected in
Files changedtab - Relevant screen shots are correctly placed
- Appropriate CodeQL alerts have been checked
- Website still works as expected
- Expected changes are reflected in the website 👍🏽
Requested Changes
- None
Thank you for your hard work! I approve this PR!
buneeIsSlo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! @Patdabaker Great work
- The branches from and to are setup correctly
- Link to the issue is included
- There is a clear and concise description of what was done and why
- Appropriate CodeQL alerts have been checked
- Screenshots of before and after the changes are included
Thanks for woking on this issue!
d021d51
|
Fixes #8016
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied