Skip to content

Conversation

@santi-jose
Copy link
Member

@santi-jose santi-jose commented Jul 2, 2025

Fixes #8122

What changes did you make?

  • Removed Daniel Franco from leadership property in Hack4LA website project markdown.

Why did you make the changes (we will use this info to test)?

  • Keeping leadership information up to date so visitors of the website can get accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

site-remove-daniel-franco-8122-before

Visuals after changes are applied

site-remove-daniel-franco-8122-after

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b santi-jose-site-remove-daniel-franco-8122 gh-pages
git pull https://github.com/santi-jose/website.git site-remove-daniel-franco-8122

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jul 2, 2025
@caz002 caz002 self-requested a review July 2, 2025 16:59
Copy link
Member

@caz002 caz002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @santi-jose ! Thank you for working on this issue.

Things Done Well

  • Changes match those requested by issue, and the correct file is modified
  • Description accurately describes changes, and why they were made
  • Images are provided and accurately describe changes
  • PR has no Code QL alerts

Requested Changes

  • clean up the summary of changes section by removing the extra bullet points in the description

After the changes are made, I will approve the pull request. Thank you!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Jul 2, 2025
@caz002
Copy link
Member

caz002 commented Jul 2, 2025

Review ETA: 7/2/2025
Availability: after 2pm M-F

@santi-jose
Copy link
Member Author

Hello @santi-jose ! Thank you for working on this issue.

Things Done Well

  • Changes match those requested by issue, and the correct file is modified
  • Description accurately describes changes, and why they were made
  • Images are provided and accurately describe changes
  • PR has no Code QL alerts

Requested Changes

  • clean up the summary of changes section by removing the extra bullet points in the description

After the changes are made, I will approve the pull request. Thank you!

Thanks for the review, I made the requested changes!

Copy link
Member

@ryanfkeller ryanfkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @santi-jose, thanks for contributing!

To me, your code changes and PR contents look good. Thanks also for addressing @caz002's comments, I don't see any issue there.

My one recommendation for the future would be to give a slightly more descriptive title if possible. I'm thinking something like "Remove Daniel Franco from HfLA Site Leadership Page" -- something that makes it super obvious what this PR is about at a glance. Your title is most of the way there, but could be a little clearer.

That said, I think nit-pick about title aside, everything looks great and I'm happy to approve as is. Nice work, and thanks again!

Copy link
Member

@caz002 caz002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing the extra bullet points in the description! I also agree with what Ryan said about making the titles slightly more descriptive to prevent any possible confusion. I approve this merge request.

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Jul 4, 2025
@mugdhchauhan
Copy link
Member

Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉

@mugdhchauhan mugdhchauhan merged commit 4db1a44 into hackforla:gh-pages Jul 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Website- Remove Daniel Franco

4 participants