-
-
Notifications
You must be signed in to change notification settings - Fork 843
Site - Remove Daniel Franco #8241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site - Remove Daniel Franco #8241
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @santi-jose ! Thank you for working on this issue.
Things Done Well
- Changes match those requested by issue, and the correct file is modified
- Description accurately describes changes, and why they were made
- Images are provided and accurately describe changes
- PR has no Code QL alerts
Requested Changes
- clean up the summary of changes section by removing the extra bullet points in the description
After the changes are made, I will approve the pull request. Thank you!
|
Review ETA: 7/2/2025 |
Thanks for the review, I made the requested changes! |
ryanfkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @santi-jose, thanks for contributing!
To me, your code changes and PR contents look good. Thanks also for addressing @caz002's comments, I don't see any issue there.
My one recommendation for the future would be to give a slightly more descriptive title if possible. I'm thinking something like "Remove Daniel Franco from HfLA Site Leadership Page" -- something that makes it super obvious what this PR is about at a glance. Your title is most of the way there, but could be a little clearer.
That said, I think nit-pick about title aside, everything looks great and I'm happy to approve as is. Nice work, and thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for removing the extra bullet points in the description! I also agree with what Ryan said about making the titles slightly more descriptive to prevent any possible confusion. I approve this merge request.
|
Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉 |
Fixes #8122
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied